Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct minor typo in testing guide #27382

Closed
wants to merge 1 commit into from
Closed

docs: correct minor typo in testing guide #27382

wants to merge 1 commit into from

Conversation

ericksoen
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@brandonroberts brandonroberts self-assigned this Dec 3, 2018
@brandonroberts brandonroberts added type: bug/fix comp: docs area: testing Issues related to Angular testing features, such as TestBed action: review The PR is still awaiting reviews from at least one requested reviewer effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR labels Dec 3, 2018
@ngbot ngbot bot added this to the Backlog milestone Dec 3, 2018
@brandonroberts brandonroberts changed the title docs: correct minor typo docs: correct minor typo in testing guide Jan 14, 2019
@brandonroberts brandonroberts removed the request for review from jenniferfell January 14, 2019 15:47
@brandonroberts brandonroberts removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 14, 2019
@ericksoen ericksoen requested a review from a team as a code owner January 14, 2019 15:48
@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jan 22, 2019
@alxhub alxhub closed this in 6324ad4 Jan 22, 2019
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@ericksoen @ngfelixl
docs: correct minor typo (angular#27382)
1ced322 
PR Close angular#27382
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Jan 29, 2019
@ericksoen @brandonroberts
docs: correct minor typo (angular#27382)
ccac6fa 
PR Close angular#27382
@brandonroberts brandonroberts mentioned this pull request Jan 29, 2019
Closed
14 tasks
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Jan 30, 2019
@ericksoen @brandonroberts
docs: correct minor typo (angular#27382)
40555cd 
PR Close angular#27382
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
@ericksoen @vetom
docs: correct minor typo (angular#27382)
5227128 
PR Close angular#27382
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Feb 4, 2019
@ericksoen @brandonroberts
docs: correct minor typo (angular#27382)
9914cd2 
PR Close angular#27382
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Feb 5, 2019
@ericksoen @brandonroberts
docs: correct minor typo (angular#27382)
20be4d9 
PR Close angular#27382
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Feb 11, 2019
@ericksoen @brandonroberts
docs: correct minor typo (angular#27382)
10b2427 
PR Close angular#27382
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Feb 19, 2019
@ericksoen @brandonroberts
docs: correct minor typo (angular#27382)
032a067 
PR Close angular#27382
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Feb 22, 2019
@ericksoen @brandonroberts
docs: correct minor typo (angular#27382)
f84d7f6 
PR Close angular#27382
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Feb 25, 2019
@ericksoen @brandonroberts
docs: correct minor typo (angular#27382)
6e1ced1 
PR Close angular#27382
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Mar 5, 2019
@ericksoen @brandonroberts
docs: correct minor typo (angular#27382)
6f0b526 
PR Close angular#27382
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Mar 12, 2019
@ericksoen @brandonroberts
docs: correct minor typo (angular#27382)
059f6d7 
PR Close angular#27382
matsko pushed a commit that referenced this pull request Mar 14, 2019
@ericksoen @matsko
docs: correct minor typo (#27382) (#28423)
495f8e1 
PR Close #27382

PR Close #28423
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees

@brandonroberts brandonroberts

Labels
action: merge The PR is ready for merge by the caretaker area: testing Issues related to Angular testing features, such as TestBed cla: yes effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericksoen @brandonroberts @googlebot