fix(ivy): adding projectDef instructions to all templates where <ng-content> is present (FW-745)
#27384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
type: bug/fix
action: review
AndrewKushnir
added
action: merge
|
@AndrewKushnir can you rebase this please? |
IgorMinar
added
the
action: cleanup
…-content> is present (FW-745) Prior to this change `projectDef` instructions were placed to root templates only, thus the necessary information (selectors) in nested templates was missing. This update adds the logic to insert `projectDef` instructions to all templates where <ng-content> is present.
AndrewKushnir
force-pushed
the
FW-745-projection-def
branch
from
ce96674
to
ac9daab
Compare
AndrewKushnir
removed
the
action: cleanup
|
@IgorMinar thanks, rebased. |
|
You can preview ac9daab at https://pr27384-ac9daab.ngbuilds.io/. |
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
…-content> is present (FW-745) (angular#27384) Prior to this change `projectDef` instructions were placed to root templates only, thus the necessary information (selectors) in nested templates was missing. This update adds the logic to insert `projectDef` instructions to all templates where <ng-content> is present. PR Close angular#27384
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…-content> is present (FW-745) (angular#27384) Prior to this change `projectDef` instructions were placed to root templates only, thus the necessary information (selectors) in nested templates was missing. This update adds the logic to insert `projectDef` instructions to all templates where <ng-content> is present. PR Close angular#27384
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change
projectDefinstructions were placed to root templates only, thus the necessary information (selectors) in nested templates was missing. This update adds the logic to insertprojectDefinstructions to all templates where is present.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?