Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): temporary hack to set host styles and static classes #27385

Closed
wants to merge 1 commit into from

Conversation

kara
Copy link
Contributor

@kara kara commented Dec 1, 2018

This PR adds another temporary hack so host style instructions don't throw in the Material demo app. It should be replaced when @matsko implements real host bindings for styles.

@kara kara requested a review from mhevery December 1, 2018 00:28
@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer comp: ivy target: major This PR is targeted for the next major release labels Dec 1, 2018
@ngbot ngbot bot added this to the needsTriage milestone Dec 1, 2018
@mary-poppins
Copy link

You can preview e76b886 at https://pr27385-e76b886.ngbuilds.io/.

@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 1, 2018
@kara
Copy link
Contributor Author

kara commented Dec 1, 2018

presubmit

@mary-poppins
Copy link

You can preview 8b8cfb3 at https://pr27385-8b8cfb3.ngbuilds.io/.

@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews state: WIP and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 1, 2018
@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Dec 1, 2018
@mary-poppins
Copy link

You can preview 13e88f5 at https://pr27385-13e88f5.ngbuilds.io/.

@mary-poppins
Copy link

You can preview ea660f4 at https://pr27385-ea660f4.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 080b238 at https://pr27385-080b238.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 60d47ae at https://pr27385-60d47ae.ngbuilds.io/.

@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 3, 2018
@mary-poppins
Copy link

You can preview 698ec05 at https://pr27385-698ec05.ngbuilds.io/.

@kara kara added the action: merge The PR is ready for merge by the caretaker label Dec 3, 2018
@alxhub alxhub closed this in 2a39425 Dec 3, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants