Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in toh-pt6.md #27403

Closed
wants to merge 1 commit into from
Closed

Conversation

volshibenik
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

File toh-pt6.md has a broken link href attribute, that leads to localhost:4800 instead of angular.io, which causes an error.

What is the new behavior?

Link works correctly

Does this PR introduce a breaking change?

  • Yes
  • No

@brandonroberts brandonroberts self-assigned this Dec 3, 2018
@brandonroberts brandonroberts added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer effort1: hours aio: preview target: patch This PR is targeted for the next patch release risk: low labels Dec 3, 2018
@mary-poppins
Copy link

You can preview c4c3620 at https://pr27403-c4c3620.ngbuilds.io/.
You can preview 7567f44 at https://pr27403-7567f44.ngbuilds.io/.

@brandonroberts brandonroberts added state: community Someone from the Angular community is working on this issue or submitted this PR docsarea: tutorial labels Dec 3, 2018
@ngbot ngbot bot added this to the Backlog milestone Dec 3, 2018
@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 3, 2018
@IgorMinar IgorMinar closed this in 931a636 Dec 3, 2018
IgorMinar pushed a commit that referenced this pull request Dec 3, 2018
@volshibenik volshibenik deleted the fix-link branch December 4, 2018 19:03
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants