feat(ivy): support WrappedValue in pipes (FW-726) #27409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 90e027b at https://pr27409-90e027b.ngbuilds.io/. |
|
You can preview 69285f1 at https://pr27409-69285f1.ngbuilds.io/. |
|
You can preview 0cb4774 at https://pr27409-0cb4774.ngbuilds.io/. |
|
You can preview adc992b at https://pr27409-adc992b.ngbuilds.io/. |
|
You can preview ab0eb6c at https://pr27409-ab0eb6c.ngbuilds.io/. |
kara
added
action: review
JoostK
reviewed
Dec 3, 2018
mhevery
approved these changes
Dec 3, 2018
|
You can preview 72c2835 at https://pr27409-72c2835.ngbuilds.io/. |
mhevery
approved these changes
Dec 4, 2018
marclaval
added
merge: caretaker note
alxhub
added
action: merge
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the support of WrappedValue in pipes.
It uses the same trick as in the ViewEngine: the result of the pipe transformation is unwrapped immediately in the pipe instruction. And, if this result is wrapped, the previous value is wrapped to force change detection.
As a result, the unwrap code is only executed for pipe output, and the WrappedValue code is imported only if a pipe is used.
This solves 21 failures in the router packages when running the tests with Ivy.