New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(bazel): replace yarn_install(name = "npm") with @npm local_repository() to speed up build #27469
Conversation
@devversion You can use the same approach in the angular/material repo to remove the |
f2e1181
to
efcbb86
Compare
…rsitory() to speed up build
the old version was failing to compile on MacOS Mojave 10.14.1.
efcbb86
to
9608578
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
I've rebased and forcepushed to this branch (I also sneaked in an fsevents update) |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
the old version was failing to compile on MacOS Mojave 10.14.1. PR Close #27469
the old version was failing to compile on MacOS Mojave 10.14.1. PR Close #27469
…rsitory() to speed up build (angular#27469) PR Close angular#27469
the old version was failing to compile on MacOS Mojave 10.14.1. PR Close angular#27469
…rsitory() to speed up build (angular#27469) PR Close angular#27469
the old version was failing to compile on MacOS Mojave 10.14.1. PR Close angular#27469
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This should shave 15s from a clean build as there is one less
yarn install
to run and also removes thenpm/tools/package.json
file which needed to be maintained