Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bazel): replace yarn_install(name = "npm") with @npm local_repository() to speed up build #27469

Closed

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Dec 5, 2018

This should shave 15s from a clean build as there is one less yarn install to run and also removes the npm/tools/package.json file which needed to be maintained

@gregmagolan
Copy link
Contributor Author

@devversion You can use the same approach in the angular/material repo to remove the tools/npm/package.json file

@gregmagolan gregmagolan added the target: patch This PR is targeted for the next patch release label Dec 5, 2018
@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Dec 5, 2018
gregmagolan and others added 2 commits December 5, 2018 10:06
the old version was failing to compile on MacOS Mojave 10.14.1.
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Dec 5, 2018
@IgorMinar
Copy link
Contributor

I've rebased and forcepushed to this branch (I also sneaked in an fsevents update)

@IgorMinar IgorMinar added cla: yes and removed cla: no labels Dec 5, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

IgorMinar pushed a commit that referenced this pull request Dec 5, 2018
IgorMinar added a commit that referenced this pull request Dec 5, 2018
the old version was failing to compile on MacOS Mojave 10.14.1.

PR Close #27469
@IgorMinar IgorMinar closed this in 68074df Dec 5, 2018
IgorMinar added a commit that referenced this pull request Dec 5, 2018
the old version was failing to compile on MacOS Mojave 10.14.1.

PR Close #27469
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
the old version was failing to compile on MacOS Mojave 10.14.1.

PR Close angular#27469
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
the old version was failing to compile on MacOS Mojave 10.14.1.

PR Close angular#27469
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants