Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): add missing AttributeMarker export #27485

Closed
wants to merge 1 commit into from
Closed

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Dec 5, 2018

No description provided.

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added target: major This PR is targeted for the next major release comp: ivy labels Dec 5, 2018
@ngbot ngbot bot added this to the needsTriage milestone Dec 5, 2018
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Dec 17, 2018
@ngbot
Copy link

ngbot bot commented Dec 17, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: integration_test" is failing
    pending status "google3" is pending
    pending status "code-review/pullapprove" is pending
    pending status "ci/circleci: build-packages-dist" is pending
    pending status "ci/circleci: test" is pending
    pending status "ci/circleci: test_aio" is pending
    pending status "ci/circleci: test_ivy_aot" is pending
    pending status "ci/circleci: lint" is pending
    pending status "ci/angular: size" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mhevery
Copy link
Contributor Author

mhevery commented Dec 18, 2018

@mhevery mhevery closed this in 7901cd8 Dec 18, 2018
@mhevery mhevery deleted the mhevery-patch-5 branch December 18, 2018 21:24
IgorMinar pushed a commit to IgorMinar/angular that referenced this pull request Dec 19, 2018
IgorMinar pushed a commit to IgorMinar/angular that referenced this pull request Dec 19, 2018
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants