Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ivy): enable router tests with pending timers (FW-768) #27509

Closed
wants to merge 1 commit into from

Conversation

marclaval
Copy link
Contributor

These two tests are failing because there are some pending timers in zone at the end of the tests.
The reasons are:

  1. the RouterOutlet.activateWith(...) marks for check to force change detection, see https://github.com/angular/angular/blob/master/packages/router/src/directives/router_outlet.ts#L137-L140
  2. In Ivy, marking a view dirty also schedules a change detection, see https://github.com/angular/angular/blob/master/packages/core/src/render3/instructions.ts#L2376-L2386
  3. In Ivy in Node, scheduling is done with setTimeout

In this list, the second one is the questionable one that should be discussed.
This PR can be merged to enable these tests which are in fact successful, or used for the discussion.

@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Dec 6, 2018
@ngbot ngbot bot added this to the needsTriage milestone Dec 6, 2018
@mary-poppins
Copy link

You can preview f55d0e4 at https://pr27509-f55d0e4.ngbuilds.io/.

@mary-poppins
Copy link

You can preview f8026f9 at https://pr27509-f8026f9.ngbuilds.io/.

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Dec 6, 2018
@mhevery mhevery self-assigned this Dec 6, 2018
@mhevery mhevery removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 6, 2018
@IgorMinar IgorMinar closed this in 8fa7e93 Dec 6, 2018
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants