Router state is Mutable via ActivatedRouteSnapshot

[the-avid-engineer]

🐞 bug report

Affected Package

@angular/router (probably)

Is this a regression?

No. It appears to have existed for a while. See #17609

Description

If you mutate existing properties on the queryParams object of an ActivatedRouteSnapshot without making a deep copy, it appears to mutate the router's internal state. Telling the router to navigate using the mutated queryParams object does not trigger a navigation event in this case.

🔬 Minimal Reproduction

https://stackblitz.com/edit/github-powged?file=src%2Fapp%2Freproduction%2Freproduction.component.ts

[the-avid-engineer]

Ideally the fix would be to automatically return a deep copy of the queryParams object, so that you can't fall into this trap

[jasonaden]

Thanks for the issue. I scheduled to take a deeper look into this shortly after the holidays. It appears there are a number of people having similar issues so I'll see what we can do to get a resolution in place for it.

[the-avid-engineer]

Is there any update on this issue?

[angular-robot]

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

[angular-robot]

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

[mebibou]

I fell into this trap as well. It did work at some point as I didn't have this issue before I upgraded to Angular 16 (but was migrating from 14)

[the-avid-engineer]

@mebibou @stonetwig @troehling

Please give this issue a 👍 if you want it fixed .. I opened this issue almost five years ago, it hasn't been worked on due to lack of votes :/