fix(ivy): add support for optional nullable injection tokens #27552
Conversation
IgorMinar
force-pushed
the
ivy/fix-fw-778-nullable-di-token
branch
from
426408e
to
58bb089
Compare
|
You can preview 426408e at https://pr27552-426408e.ngbuilds.io/. |
|
You can preview 58bb089 at https://pr27552-58bb089.ngbuilds.io/. |
| @@ -185,6 +213,10 @@ function expectParameter( | |||
| } | |||
|
|
|||
| function argExpressionToString(name: ts.Node): string { | |||
| if (name == null) { | |||
There was a problem hiding this comment.
This check seems to go against the type of this function - let's change the type to be nullable.
There was a problem hiding this comment.
When does it return null?
There was a problem hiding this comment.
this is just a helper function that is called after expect(foo).not.toBeNull() which in jasmine doesn't abort the rest of the expectations, so if we don't check for nulls here, the tests blows up if that expectation fails.
IgorMinar
force-pushed
the
ivy/fix-fw-778-nullable-di-token
branch
from
58bb089
to
c1e4163
Compare
IgorMinar
added
action: merge
|
You can preview c1e4163 at https://pr27552-c1e4163.ngbuilds.io/. |
|
You can preview 0035d4b at https://pr27552-0035d4b.ngbuilds.io/. |
FW-778 #resolve
IgorMinar
force-pushed
the
ivy/fix-fw-778-nullable-di-token
branch
from
0035d4b
to
6169720
Compare
|
You can preview 6169720 at https://pr27552-6169720.ngbuilds.io/. |
…#27552) FW-778 #resolve PR Close angular#27552
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
FW-778 #resolve