Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: ts-api-guardian tsconfig warning with bazel #27583

Closed
wants to merge 1 commit into from
Closed

build: ts-api-guardian tsconfig warning with bazel #27583

wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

  • Suppresses the warning from the Bazel TypeScript rules about overwritten options from the tools/tsconfig.json file. This is the only remaining warning that makes our Bazel build on Angular Material "dirty"

@devversion
build: ts-api-guardian tsconfig warning with bazel
aa59bf6 
* Suppresses the warning from the Bazel TypeScript rules about overwritten options from the `tools/tsconfig.json` file. This is the only remaining warning that makes our Bazel build on Angular Material "dirty"
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 10, 2018
IgorMinar
IgorMinar approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 13, 2018
@ngbot ngbot bot added this to the needsTriage milestone Dec 13, 2018
@mhevery mhevery closed this in e269274 Dec 13, 2018
mhevery pushed a commit that referenced this pull request Dec 13, 2018
@devversion @mhevery
build: ts-api-guardian tsconfig warning with bazel (#27583)
a808c7d 
* Suppresses the warning from the Bazel TypeScript rules about overwritten options from the `tools/tsconfig.json` file. This is the only remaining warning that makes our Bazel build on Angular Material "dirty"

PR Close #27583
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@devversion @ngfelixl
build: ts-api-guardian tsconfig warning with bazel (angular#27583)
2e2aadb 
* Suppresses the warning from the Bazel TypeScript rules about overwritten options from the `tools/tsconfig.json` file. This is the only remaining warning that makes our Bazel build on Angular Material "dirty"

PR Close angular#27583
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devversion @IgorMinar @googlebot