Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update rules_typescript #27586

Closed
wants to merge 2 commits into from
Closed

build: update rules_typescript #27586

wants to merge 2 commits into from

Conversation

alexeagle
Copy link
Contributor

This release of rules_typescript fixes a critical bug: typescript code
was not checked at all, including type-checking, tsetse, and strict deps

fixes #27569

@mary-poppins
Copy link

You can preview 19b226d at https://pr27586-19b226d.ngbuilds.io/.

@mary-poppins
Copy link

You can preview d339390 at https://pr27586-d339390.ngbuilds.io/.

@IgorMinar IgorMinar added the target: patch This PR is targeted for the next patch release label Dec 10, 2018
IgorMinar
IgorMinar reviewed Dec 10, 2018
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing. I asked @jasonaden to help the compilation errors in //packages/benchpress

@mary-poppins
Copy link

You can preview afebec7 at https://pr27586-afebec7.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 72d98c4 at https://pr27586-72d98c4.ngbuilds.io/.

@alexeagle
build: update rules_typescript
9feb105 
This release of rules_typescript fixes a critical bug: typescript code
was not checked at all, including type-checking, tsetse, and strict deps

fixes angular#27569
@alexeagle
build: fix type-check errors introduced during rules_ts 0.21
627624f
@mary-poppins
Copy link

You can preview ea0a3d6 at https://pr27586-ea0a3d6.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 627624f at https://pr27586-627624f.ngbuilds.io/.

@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Dec 10, 2018
@alxhub alxhub added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Dec 11, 2018
@alxhub alxhub closed this in bf57e9d Dec 11, 2018
alxhub pushed a commit that referenced this pull request Dec 11, 2018
@alexeagle @alxhub
build: fix type-check errors introduced during rules_ts 0.21 (#27586)
50687e1 
PR Close #27586
alexeagle added a commit to alexeagle/angular that referenced this pull request Dec 11, 2018
@alexeagle
build: update rules_typescript (angular#27586)
6bc5de3 
This release of rules_typescript fixes a critical bug: typescript code
was not checked at all, including type-checking, tsetse, and strict deps

fixes angular#27569

PR Close angular#27586
alexeagle added a commit to alexeagle/angular that referenced this pull request Dec 11, 2018
@alexeagle
build: fix type-check errors introduced during rules_ts 0.21 (angular…
f14bb1e 
…#27586)

PR Close angular#27586
alxhub pushed a commit that referenced this pull request Dec 11, 2018
@alexeagle @alxhub
build: update rules_typescript (#27586) (#27590)
7b1f352 
This release of rules_typescript fixes a critical bug: typescript code
was not checked at all, including type-checking, tsetse, and strict deps

fixes #27569

PR Close #27586

PR Close #27590
alxhub pushed a commit that referenced this pull request Dec 11, 2018
@alexeagle @alxhub
build: fix type-check errors introduced during rules_ts 0.21 (#27586) (…
01114dc 
…#27590)

PR Close #27586

PR Close #27590
This was referenced Dec 12, 2018
Closed
Closed
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@alexeagle @ngfelixl
build: update rules_typescript (angular#27586)
3d36132 
This release of rules_typescript fixes a critical bug: typescript code
was not checked at all, including type-checking, tsetse, and strict deps

fixes angular#27569

PR Close angular#27586
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@alexeagle @ngfelixl
build: fix type-check errors introduced during rules_ts 0.21 (angular…
2aad158 
…#27586)

PR Close angular#27586
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors in ts_library are not breaking builds
5 participants
@alexeagle @mary-poppins @IgorMinar @alxhub @googlebot