fix(ivy): avoid destroy renderer method invocation for child views #27592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
type: bug/fix
action: review
kara
approved these changes
Dec 11, 2018
kara
added
action: cleanup
|
You can preview b73efa2 at https://pr27592-b73efa2.ngbuilds.io/. |
|
Thanks for the review @kara! I've updated the code, will wait for tests to pass and add the |
|
You can preview cc0466c at https://pr27592-cc0466c.ngbuilds.io/. |
AndrewKushnir
added
action: merge
mhevery
added
merge: caretaker note
Since Renderer is shared across root and child views, we need to avoid `destroy` method invocation for child views and only invoke is for root view when needed. Prior to this change, the `destroy` function was called whenever child view was destroyed, thus causing errors at runtime.
alxhub
force-pushed
the
FW-801_host_element_of_undefined-v3
branch
from
cc0466c
to
6142983
Compare
|
You can preview 6142983 at https://pr27592-6142983.ngbuilds.io/. |
alxhub
removed
the
merge: caretaker note
|
Rebased after #27586 |
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…ngular#27592) Since Renderer is shared across root and child views, we need to avoid `destroy` method invocation for child views and only invoke is for root view when needed. Prior to this change, the `destroy` function was called whenever child view was destroyed, thus causing errors at runtime. PR Close angular#27592
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Renderer is shared across root and child views, we need to avoid
destroymethod invocation for child views and only invoke is for root view when needed. Prior to this change, thedestroyfunction was called whenever child view was destroyed, thus causing errors at runtime.As a part of this PR, the
MockRendererFactorywas moved torender_util.ts, so it can be leveraged in other tests when needed.This PR resolves issue FW-801.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?