Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in dependency injection guide #27616

Closed
wants to merge 1 commit into from

Conversation

ashinzekene
Copy link
Contributor

@ashinzekene ashinzekene commented Dec 12, 2018

Fixed typo

HeroService must provided in some parent injector
HeroService must be provided in some parent injector

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

HeroService must provided in some parent injector

Issue Number: N/A

What is the new behavior?

HeroService must be provided in some parent injector

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

HeroService must provided in some parent injector
HeroService must be provided in some parent injector

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@brandonroberts brandonroberts added comp: docs effort1: hours state: blocked target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR labels Dec 13, 2018
@ngbot ngbot bot added this to the Backlog milestone Dec 13, 2018
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update git commit message to docs: fix typo in dependency injection guide

@brandonroberts
Copy link
Contributor

brandonroberts commented Dec 13, 2018

Thanks for the PR @ashinzekene! You must sign the CLA before this PR can move forward. You also need to update the git commit message.

After this PR gets reviewed, is approved, and is green on CI, its ready to merge.

@brandonroberts brandonroberts self-assigned this Dec 13, 2018
@ashinzekene ashinzekene changed the title docs Update dependency-injection.md docs (angular.io) Update dependency-injection.md Dec 13, 2018
@googlebot
Copy link

CLAs look good, thanks!

@ashinzekene
Copy link
Contributor Author

Done @brandonroberts

~~`HeroService` must provided in some parent injector~~
*`HeroService` must be provided in some parent injector*
@brandonroberts brandonroberts changed the title docs (angular.io) Update dependency-injection.md docs: fix typo in dependency injection guide … Dec 28, 2018
@brandonroberts brandonroberts changed the title docs: fix typo in dependency injection guide … docs: fix typo in dependency injection guide Dec 28, 2018
@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Jan 14, 2019
AndrewKushnir pushed a commit that referenced this pull request Jan 14, 2019
~~`HeroService` must provided in some parent injector~~
*`HeroService` must be provided in some parent injector*

PR Close #27616
petebacondarwin pushed a commit to petebacondarwin/angular that referenced this pull request Jan 14, 2019
~~`HeroService` must provided in some parent injector~~
*`HeroService` must be provided in some parent injector*

PR Close angular#27616
AndrewKushnir pushed a commit that referenced this pull request Jan 16, 2019
~~`HeroService` must provided in some parent injector~~
*`HeroService` must be provided in some parent injector*

PR Close #27616
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 18, 2019
~~`HeroService` must provided in some parent injector~~
*`HeroService` must be provided in some parent injector*

PR Close angular#27616
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 18, 2019
~~`HeroService` must provided in some parent injector~~
*`HeroService` must be provided in some parent injector*

PR Close angular#27616
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
~~`HeroService` must provided in some parent injector~~
*`HeroService` must be provided in some parent injector*

PR Close angular#27616
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants