test(ivy): remove stale fixmes from //packages/platform-server #27639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorMinar
added
target: major
|
You can preview 0278b64 at https://pr27639-0278b64.ngbuilds.io/. |
these issues have already been resolved but we forgot to reenable the tests.
IgorMinar
force-pushed
the
ivy/remove-stale-fixmes
branch
from
0278b64
to
2c3b6ca
Compare
|
You can preview 2c3b6ca at https://pr27639-2c3b6ca.ngbuilds.io/. |
the old one was not detailed enough
|
You can preview 5bc39fa at https://pr27639-5bc39fa.ngbuilds.io/. |
IgorMinar
changed the title
…ntegration_spec.ts the issues referenced were stale and unrelated.
|
You can preview 242bcec at https://pr27639-242bcec.ngbuilds.io/. |
IgorMinar
added
the
merge: caretaker note
|
caretaker note: saucelabs flaked |
IgorMinar
removed
the
merge: caretaker note
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…ngular#27639) these issues have already been resolved but we forgot to reenable the tests. PR Close angular#27639
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
angular#27639) the old one was not detailed enough PR Close angular#27639
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…ntegration_spec.ts (angular#27639) the issues referenced were stale and unrelated. PR Close angular#27639
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these issues have already been resolved but we forgot to reenable the tests.