build: improve error message for upgrade test helper #27706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 477f300 at https://pr27706-477f300.ngbuilds.io/. |
|
You can preview 7893a3e at https://pr27706-7893a3e.ngbuilds.io/. |
gkalpak
reviewed
Dec 17, 2018
gkalpak
added
refactoring
Currently whenever the upgrade test helper fails to load a given AngularJS version, the error that will be rejected is technically not an error because the `onerror` callback is not returning an error, but an "ErrorEvent". Since that `ErrorEvent` is basically just rejected, browsers will print the error as followed: ``` Failed: [object Event] ``` This is not helpful at all and also implies that there _might_ be more information hidden within the `Event` instance. Unfortunately that's not the case (at least on browsers we test against) and the logic to extract the data from the event would be not worth the effort, we just return a simple custom `Error` that won't imply that there is more information hidden.
devversion
force-pushed
the
build/better-error-task-helpers
branch
from
7893a3e
to
00543b9
Compare
|
You can preview 00543b9 at https://pr27706-00543b9.ngbuilds.io/. |
devversion
added
the
action: review
gkalpak
approved these changes
Dec 17, 2018
gkalpak
added
target: patch
mhevery
pushed a commit
that referenced
this pull request
Dec 18, 2018
Currently whenever the upgrade test helper fails to load a given AngularJS version, the error that will be rejected is technically not an error because the `onerror` callback is not returning an error, but an "ErrorEvent". Since that `ErrorEvent` is basically just rejected, browsers will print the error as followed: ``` Failed: [object Event] ``` This is not helpful at all and also implies that there _might_ be more information hidden within the `Event` instance. Unfortunately that's not the case (at least on browsers we test against) and the logic to extract the data from the event would be not worth the effort, we just return a simple custom `Error` that won't imply that there is more information hidden. PR Close #27706
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
Currently whenever the upgrade test helper fails to load a given AngularJS version, the error that will be rejected is technically not an error because the `onerror` callback is not returning an error, but an "ErrorEvent". Since that `ErrorEvent` is basically just rejected, browsers will print the error as followed: ``` Failed: [object Event] ``` This is not helpful at all and also implies that there _might_ be more information hidden within the `Event` instance. Unfortunately that's not the case (at least on browsers we test against) and the logic to extract the data from the event would be not worth the effort, we just return a simple custom `Error` that won't imply that there is more information hidden. PR Close angular#27706
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently whenever the upgrade test helper fails to load a given AngularJS version, the error that will be rejected is technically not an error because the
onerrorcallback is not returning an error, but an "ErrorEvent".Since that
ErrorEventis basically just rejected, browsers will print the error as followed:This is not helpful at all and also implies that there might be more information hidden within the
Eventinstance. Unfortunately that's not the case (at least on browsers we test against) and the logic to extract the data from the event would be not worth the effort, we just return a simple customErrorthat won't imply that there is more information hidden.