New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: load angular.js minified output in upgrade tests #27711
build: load angular.js minified output in upgrade tests #27711
Conversation
* We should try loading Angular.JS for the upgrade tests in their minfied output. There seems to be a lot flakiness in regards to loading `AngularJS` within Travis, and the `onerror` messages aren't really too helpful. In order to reduce the payload that will be passed through the Saucelabs tunnel, we should try to load the minfied output files.
You can preview b59c2c1 at https://pr27711-b59c2c1.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed "offline", this change will make it harder to debug failing tests locally, but is worth it if it will make the CI more stable.
Could you make it easier to switch to the none-minified version (for when we want to run and debug tests locally). E.g. serve both minified and non-minified files and have a flag in test_helpers.ts
the determines which ones to use. (It will use the minified ones, but we would be able to switch to non-minified by flipping that flag.
@gkalpak That sounds like a good idea. How would that work with the Bazel and Karma configuration? Should we just add the unminifed Angular versions to the karma config? (they won't be included anyway) And for Bazel, we can just declare the unminfied Angular version also as |
I don't know much about bazel, but my thought was including both minified and non-minified (to both karma files and bazel). I don't think bazel will mind and those files will change very infrequently. |
Allow switching between unminifed and minified AngularJS
You can preview 1593da4 at https://pr27711-1593da4.ngbuilds.io/. |
@gkalpak Addressed your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
* We should try loading Angular.JS for the upgrade tests in their minfied output. There seems to be a lot flakiness in regards to loading `AngularJS` within Travis, and the `onerror` messages aren't really too helpful. In order to reduce the payload that will be passed through the Saucelabs tunnel, we should try to load the minfied output files. PR Close #27711
* We should try loading Angular.JS for the upgrade tests in their minfied output. There seems to be a lot flakiness in regards to loading `AngularJS` within Travis, and the `onerror` messages aren't really too helpful. In order to reduce the payload that will be passed through the Saucelabs tunnel, we should try to load the minfied output files. PR Close angular#27711
* We should try loading Angular.JS for the upgrade tests in their minfied output. There seems to be a lot flakiness in regards to loading `AngularJS` within Travis, and the `onerror` messages aren't really too helpful. In order to reduce the payload that will be passed through the Saucelabs tunnel, we should try to load the minfied output files. PR Close angular#27711
* We should try loading Angular.JS for the upgrade tests in their minfied output. There seems to be a lot flakiness in regards to loading `AngularJS` within Travis, and the `onerror` messages aren't really too helpful. In order to reduce the payload that will be passed through the Saucelabs tunnel, we should try to load the minfied output files. PR Close angular#27711
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
We should try loading Angular.JS for the upgrade tests in their minfied output.
There seems to be a lot flakiness in regards to loading
AngularJS
within Travis, and theonerror
messages aren't really too helpful. In order to reduce the payload that will be passed through the Saucelabs tunnel, we should try to load the minfied output files.