Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: load angular.js minified output in upgrade tests #27711

Conversation

devversion
Copy link
Member

@devversion devversion commented Dec 17, 2018

We should try loading Angular.JS for the upgrade tests in their minfied output.

There seems to be a lot flakiness in regards to loading AngularJS within Travis, and the onerror messages aren't really too helpful. In order to reduce the payload that will be passed through the Saucelabs tunnel, we should try to load the minfied output files.

* We should try loading Angular.JS for the upgrade tests in their minfied output. There seems to be a lot flakiness in regards to loading `AngularJS` within Travis, and the `onerror` messages aren't really too helpful. In order to reduce the payload that will be passed through the Saucelabs tunnel, we should try to load the minfied output files.
@mary-poppins
Copy link

You can preview b59c2c1 at https://pr27711-b59c2c1.ngbuilds.io/.

@devversion devversion added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 17, 2018
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed "offline", this change will make it harder to debug failing tests locally, but is worth it if it will make the CI more stable.

Could you make it easier to switch to the none-minified version (for when we want to run and debug tests locally). E.g. serve both minified and non-minified files and have a flag in test_helpers.ts the determines which ones to use. (It will use the minified ones, but we would be able to switch to non-minified by flipping that flag.

@devversion
Copy link
Member Author

devversion commented Dec 17, 2018

@gkalpak That sounds like a good idea. How would that work with the Bazel and Karma configuration? Should we just add the unminifed Angular versions to the karma config? (they won't be included anyway)

And for Bazel, we can just declare the unminfied Angular version also as srcs, but that feels like an anti-pattern. Any ideas?

@gkalpak
Copy link
Member

gkalpak commented Dec 17, 2018

I don't know much about bazel, but my thought was including both minified and non-minified (to both karma files and bazel). I don't think bazel will mind and those files will change very infrequently.

Allow switching between unminifed and minified AngularJS
@mary-poppins
Copy link

You can preview 1593da4 at https://pr27711-1593da4.ngbuilds.io/.

@devversion
Copy link
Member Author

@gkalpak Addressed your feedback.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 18, 2018
@ngbot ngbot bot added this to the needsTriage milestone Dec 18, 2018
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

mhevery pushed a commit that referenced this pull request Dec 18, 2018
* We should try loading Angular.JS for the upgrade tests in their minfied output. There seems to be a lot flakiness in regards to loading `AngularJS` within Travis, and the `onerror` messages aren't really too helpful. In order to reduce the payload that will be passed through the Saucelabs tunnel, we should try to load the minfied output files.

PR Close #27711
@mhevery mhevery closed this in 1b6c4e7 Dec 18, 2018
IgorMinar pushed a commit to IgorMinar/angular that referenced this pull request Dec 19, 2018
* We should try loading Angular.JS for the upgrade tests in their minfied output. There seems to be a lot flakiness in regards to loading `AngularJS` within Travis, and the `onerror` messages aren't really too helpful. In order to reduce the payload that will be passed through the Saucelabs tunnel, we should try to load the minfied output files.

PR Close angular#27711
IgorMinar pushed a commit to IgorMinar/angular that referenced this pull request Dec 19, 2018
* We should try loading Angular.JS for the upgrade tests in their minfied output. There seems to be a lot flakiness in regards to loading `AngularJS` within Travis, and the `onerror` messages aren't really too helpful. In order to reduce the payload that will be passed through the Saucelabs tunnel, we should try to load the minfied output files.

PR Close angular#27711
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
* We should try loading Angular.JS for the upgrade tests in their minfied output. There seems to be a lot flakiness in regards to loading `AngularJS` within Travis, and the `onerror` messages aren't really too helpful. In order to reduce the payload that will be passed through the Saucelabs tunnel, we should try to load the minfied output files.

PR Close angular#27711
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants