fix(ivy): implement 'TestBed.overrideTemplateUsingTestingModule' function #27717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
action: review
|
You can preview 8a6afb1 at https://pr27717-8a6afb1.ngbuilds.io/. |
alxhub
approved these changes
Dec 19, 2018
| return meta; | ||
| const hasTemplateOverride = !!type && this._templateOverrides.has(type); | ||
| if (hasTemplateOverride) { | ||
| overrides.template = this._templateOverrides.get(type !); |
There was a problem hiding this comment.
Maybe clear out templateUrl here too.
|
You can preview b2cf895 at https://pr27717-b2cf895.ngbuilds.io/. |
…tion Adding 'TestBed.overrideTemplateUsingTestingModule' function that overrides Component template and uses TestingModule as a scope.
AndrewKushnir
force-pushed
the
FW-851_override_template_using_testing_module
branch
from
b2cf895
to
b105ccc
Compare
|
You can preview b105ccc at https://pr27717-b105ccc.ngbuilds.io/. |
AndrewKushnir
added
action: merge
devversion
pushed a commit
to devversion/angular
that referenced
this pull request
Jan 9, 2019
…tion (angular#27717) Adding 'TestBed.overrideTemplateUsingTestingModule' function that overrides Component template and uses TestingModule as a scope. PR Close angular#27717
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…tion (angular#27717) Adding 'TestBed.overrideTemplateUsingTestingModule' function that overrides Component template and uses TestingModule as a scope. PR Close angular#27717
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding 'TestBed.overrideTemplateUsingTestingModule' function that overrides Component template and uses TestingModule as a scope.
Update (12/25): rebased from the latest master.
This PR resolves FW-851.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?