Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): resolve forwardRefs correctly in TestBed #27737

Closed
wants to merge 5 commits into from
Closed

fix(ivy): resolve forwardRefs correctly in TestBed #27737

wants to merge 5 commits into from

Conversation

AndrewKushnir
Copy link
Contributor

Forward refs in some places (like imports/export/providers/viewProviders/queries) were not resolved before passing to compilation phase. Now we resolve missing refs before invoking compile function.

I also updated root causes for some tests from FW-756: Pipes and directives from imported modules are not taken into account to FW-681: TestBed: not possible to retrieve host property bindings for DebugElement, since the problem described in FW-756 seems to be resolved.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Dec 18, 2018
@ngbot ngbot bot modified the milestone: needsTriage Dec 18, 2018
alxhub
alxhub previously requested changes Dec 19, 2018
View reviewed changes
packages/core/src/render3/jit/directive.ts Outdated Show resolved Hide resolved
packages/core/src/render3/jit/module.ts Outdated Show resolved Hide resolved
packages/core/testing/src/r3_test_bed.ts Outdated Show resolved Hide resolved
@AndrewKushnir AndrewKushnir removed the request for review from mhevery December 19, 2018 23:17
@AndrewKushnir
Copy link
Contributor Author

Thanks for review @alxhub! I've removed forward ref resolution from providers and viewProviders. Could you plz have another look?

@angular angular deleted a comment from mary-poppins Dec 21, 2018
@angular angular deleted a comment from mary-poppins Dec 21, 2018
@angular angular deleted a comment from mary-poppins Dec 21, 2018
@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Dec 21, 2018 •
edited

Presubmit

kara
kara approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 21, 2018
@kara kara dismissed alxhub’s stale review December 21, 2018 19:37

Comments should be resolved, and we're about to go on a few week holiday break. If more comments, we can do in a follow-up.

@IgorMinar
Copy link
Contributor

@AndrewKushnir can you please resolve the conflict?

@kara kara added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Dec 22, 2018
@ngbot
Copy link

ngbot bot commented Dec 22, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure conflicts with base branch "master"
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Dec 24, 2018
@AndrewKushnir
fix(ivy): resolve forwardRefs correctly in TestBed (JIT)
c5e8bd2 
Forward refs in some places (like imports/export/providers/viewProviders/queries) were not resolved before passing to compilation phase. Now we resolve missing refs before invoking compile function.
@mary-poppins
Copy link

You can preview 64f2c22 at https://pr27737-64f2c22.ngbuilds.io/.

@AndrewKushnir
Copy link
Contributor Author

Presubmit #2

@angular angular deleted a comment from mary-poppins Dec 27, 2018
@angular angular deleted a comment from mary-poppins Dec 27, 2018
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 27, 2018
@ocombe ocombe mentioned this pull request Jan 3, 2019
Closed
@benlesh benlesh closed this in a979001 Jan 3, 2019
@alippai alippai mentioned this pull request Jan 4, 2019
Closed
devversion pushed a commit to devversion/angular that referenced this pull request Jan 9, 2019
@AndrewKushnir @devversion
fix(ivy): resolve forwardRefs correctly in TestBed (JIT) (angular#2…
8b911d8 
…7737)

Forward refs in some places (like imports/export/providers/viewProviders/queries) were not resolved before passing to compilation phase. Now we resolve missing refs before invoking compile function.

PR Close angular#27737
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@AndrewKushnir @ngfelixl
fix(ivy): resolve forwardRefs correctly in TestBed (JIT) (angular#2…
6aea698 
…7737)

Forward refs in some places (like imports/export/providers/viewProviders/queries) were not resolved before passing to compilation phase. Now we resolve missing refs before invoking compile function.

PR Close angular#27737
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfaproject alfaproject alfaproject left review comments

@IgorMinar IgorMinar IgorMinar approved these changes

@kara kara kara approved these changes

@alxhub alxhub alxhub left review comments

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@AndrewKushnir @IgorMinar @mary-poppins @alfaproject @kara @alxhub @googlebot