Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bazel): Make sure CLI project created with Bazel works with orig… #27741

Closed
wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Dec 18, 2018

…inal workflow

Bazel bits added to a CLI project should not be destructive.
The project should still work under the original CLI workflow.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alexeagle
Copy link
Contributor

please make an assertion that fails since the index.html still has broken script tags we added

@kyliau
Copy link
Contributor Author

kyliau commented Dec 19, 2018

@alexeagle
I manually verified that the test fails with script tags in index.html
Added TODO to not copy original index.html once we have web_package rule working.
Meanwhile I'll add the protractor logs assertion to CLI.
PTAL, thanks!

…inal workflow

Bazel bits added to a CLI project should not be destructive.
The project should still work under the original CLI workflow.
@alexeagle alexeagle added the target: patch This PR is targeted for the next patch release label Dec 19, 2018
@kyliau kyliau added action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules labels Dec 19, 2018
@ngbot ngbot bot added this to the needsTriage milestone Dec 19, 2018
@matsko matsko closed this in b08f3ac Dec 19, 2018
matsko pushed a commit that referenced this pull request Dec 19, 2018
…inal workflow (#27741)

Bazel bits added to a CLI project should not be destructive.
The project should still work under the original CLI workflow.

PR Close #27741
@kyliau kyliau deleted the intg_test branch January 15, 2019 18:09
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
…inal workflow (angular#27741)

Bazel bits added to a CLI project should not be destructive.
The project should still work under the original CLI workflow.

PR Close angular#27741
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants