Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix our copy of Array#find typing #27742

Closed
wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Contributor

It should be nullable, matching the lib.es2015.d.ts from TypeScript

@alexeagle alexeagle added the target: patch This PR is targeted for the next patch release label Dec 19, 2018
@alexeagle
Copy link
Contributor Author

Note, this is a pre-factoring for deleting the es6-subset.d.ts

@mary-poppins
Copy link

You can preview 4121e15 at https://pr27742-4121e15.ngbuilds.io/.

It should be nullable, matching the lib.es2015.d.ts from TypeScript
@mary-poppins
Copy link

You can preview 9dccf55 at https://pr27742-9dccf55.ngbuilds.io/.

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Dec 19, 2018
@matsko matsko removed the cla: yes label Dec 19, 2018
@matsko matsko closed this in e8f7241 Dec 19, 2018
matsko pushed a commit that referenced this pull request Dec 19, 2018
It should be nullable, matching the lib.es2015.d.ts from TypeScript

PR Close #27742
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
It should be nullable, matching the lib.es2015.d.ts from TypeScript

PR Close angular#27742
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants