fix(ivy): ensure component/directive class selectors are properly understood
#27849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsko
changed the title
class selectors are properly understoodclass selectors are properly understood
matsko
force-pushed
the
issue_FW-833
branch
2 times, most recently
from
9de6565
to
365c02e
Compare
|
You can preview 9872d88 at https://pr27849-9872d88.ngbuilds.io/. |
|
You can preview 9de6565 at https://pr27849-9de6565.ngbuilds.io/. |
|
You can preview 365c02e at https://pr27849-365c02e.ngbuilds.io/. |
mhevery
approved these changes
Dec 28, 2018
kara
added
action: cleanup
|
You can preview 2277521 at https://pr27849-2277521.ngbuilds.io/. |
| } | ||
| }); | ||
| const main = TestBed.createComponent(MainComp); | ||
| fit('should project a single class-based tag', () => { |
|
You can preview 552b267 at https://pr27849-552b267.ngbuilds.io/. |
|
You can preview 386a663 at https://pr27849-386a663.ngbuilds.io/. |
|
You can preview cf66990 at https://pr27849-cf66990.ngbuilds.io/. |
kara
removed
the
action: cleanup
|
You can preview 34979bd at https://pr27849-34979bd.ngbuilds.io/. |
…nderstood Angular allows for `<ng-content>` elements to include a selector which filters which content-projected entries are inserted into the container depending on whether or not the selector is matched. With Ivy this feature has not fully worked due to the massive changes that took place inside of Ivy's styling algorithm code (which is responsible for assigning classes and styles to an element). This fix ensures that content-projection can correctly identify which slot an element should be placed into when class-based selectors are used.
|
You can preview cc14acc at https://pr27849-cc14acc.ngbuilds.io/. |
pkozlowski-opensource
pushed a commit
to pkozlowski-opensource/angular
that referenced
this pull request
Jan 15, 2019
…nderstood Angular allows for `<ng-content>` elements to include a selector which filters which content-projected entries are inserted into the container depending on whether or not the selector is matched. With Ivy this feature has not fully worked due to the massive changes that took place inside of Ivy's styling algorithm code (which is responsible for assigning classes and styles to an element). This fix ensures that content-projection can correctly identify which slot an element should be placed into when class-based selectors are used. Closes angular#27849
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Jan 18, 2019
…nderstood (angular#27849) Angular allows for `<ng-content>` elements to include a selector which filters which content-projected entries are inserted into the container depending on whether or not the selector is matched. With Ivy this feature has not fully worked due to the massive changes that took place inside of Ivy's styling algorithm code (which is responsible for assigning classes and styles to an element). This fix ensures that content-projection can correctly identify which slot an element should be placed into when class-based selectors are used. PR Close angular#27849
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Jan 18, 2019
…nderstood (angular#27849) Angular allows for `<ng-content>` elements to include a selector which filters which content-projected entries are inserted into the container depending on whether or not the selector is matched. With Ivy this feature has not fully worked due to the massive changes that took place inside of Ivy's styling algorithm code (which is responsible for assigning classes and styles to an element). This fix ensures that content-projection can correctly identify which slot an element should be placed into when class-based selectors are used. PR Close angular#27849
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…nderstood (angular#27849) Angular allows for `<ng-content>` elements to include a selector which filters which content-projected entries are inserted into the container depending on whether or not the selector is matched. With Ivy this feature has not fully worked due to the massive changes that took place inside of Ivy's styling algorithm code (which is responsible for assigning classes and styles to an element). This fix ensures that content-projection can correctly identify which slot an element should be placed into when class-based selectors are used. PR Close angular#27849
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular allows for
<ng-content>elements to include a selector whichfilters which content-projected entries are inserted into the container
depending on whether or not the selector is matched.
With Ivy this feature has not fully worked due to the massive changes
that took place inside of Ivy's styling algorithm code (which is
responsible for assigning classes and styles to an element). This
fix ensures that content-projection can correctly identify which slot
an element should be placed into when class-based selectors are used.