Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): pipes should overwrite pipes with later entry in the pipes array #27910

Closed
wants to merge 1 commit into from
Closed

fix(ivy): pipes should overwrite pipes with later entry in the pipes array #27910

wants to merge 1 commit into from

Conversation

marclaval
Copy link
Contributor

@marclaval marclaval commented Jan 3, 2019 •
edited

This PR fixes FW-894.

@mary-poppins
Copy link

You can preview 9027f9a at https://pr27910-9027f9a.ngbuilds.io/.

@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Jan 3, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 3, 2019
@mary-poppins
Copy link

You can preview 96466eb at https://pr27910-96466eb.ngbuilds.io/.

petebacondarwin
petebacondarwin reviewed Jan 3, 2019
View reviewed changes
packages/core/src/render3/pipe.ts
@@ -55,7 +55,7 @@ export function pipe(index: number, pipeName: string): any {
*/
function getPipeDef(name: string, registry: PipeDefList | null): PipeDef<any> {
if (registry) {
for (let i = 0; i < registry.length; i++) {
for (let i = registry.length - 1; i >= 0; i--) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this performance critical? Maybe a compiler might optimize this for you but you could avoid computing the length-1 each loop by assigning it to a constant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B...but...he's not computing it each loop 😕
Or did you mean not to compute it on each getPipeDef() call?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL! Sorry. Not actually reading the code.

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 3, 2019
@ngbot
Copy link

ngbot bot commented Jan 3, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jan 4, 2019
@AndrewKushnir
Copy link
Contributor

@marclaval could you please rebase from the latest master and resolve conflict (and add "merge" label back)? Thank you.

@mary-poppins
Copy link

You can preview 004fca9 at https://pr27910-004fca9.ngbuilds.io/.

@marclaval marclaval added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 4, 2019
@marclaval
Copy link
Contributor Author

PR rebased and ready for merge

@kara
Copy link
Contributor

kara commented Jan 4, 2019

presubmit

@kara kara closed this in 0bd9deb Jan 4, 2019
devversion pushed a commit to devversion/angular that referenced this pull request Jan 9, 2019
@marclaval @devversion
fix(ivy): pipes should overwrite pipes with later entry in the pipes …
eb54019 
…array (angular#27910)

PR Close angular#27910
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@marclaval @ngfelixl
fix(ivy): pipes should overwrite pipes with later entry in the pipes …
08f7b8e 
…array (angular#27910)

PR Close angular#27910
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin left review comments

@gkalpak gkalpak gkalpak left review comments

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@marclaval @mary-poppins @AndrewKushnir @kara @petebacondarwin @mhevery @gkalpak @googlebot