fix(ivy): don't throw in i18nAttributes when a component is re-rendered
#27911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ered `i18nAttributes` was throwing an error when it was called multiple times in the create part of the template function with the same index, for example when we create multiple components with the same template. It shouldn't throw in this case, and just use the cache when available. FW-903 #resolve
ocombe
added
action: review
|
You can preview 5f13d47 at https://pr27911-5f13d47.ngbuilds.io/. |
|
Presubmit (passed) |
AndrewKushnir
removed
the
action: review
|
@ocombe since the i18n integration tests via TestBed are now in master, could you plz update the i18n_integration_spec.ts and remove |
|
@kara could you plz have a quick look at this PR too and approve if everything looks good to you (so we can merge it)? Thank you. |
AndrewKushnir
added
the
action: review
kara
removed
the
action: review
devversion
pushed a commit
to devversion/angular
that referenced
this pull request
Jan 9, 2019
…ered (angular#27911) `i18nAttributes` was throwing an error when it was called multiple times in the create part of the template function with the same index, for example when we create multiple components with the same template. It shouldn't throw in this case, and just use the cache when available. FW-903 #resolve PR Close angular#27911
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…ered (angular#27911) `i18nAttributes` was throwing an error when it was called multiple times in the create part of the template function with the same index, for example when we create multiple components with the same template. It shouldn't throw in this case, and just use the cache when available. FW-903 #resolve PR Close angular#27911
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i18nAttributeswas throwing an error when it was called multiple times in the create part of the template function with the same index, for example when we create multiple components with the same template. It shouldn't throw in this case, and just use the cache when available.FW-903 #resolve