Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dot segments from path not removed #27929

Open
ghost opened this issue Jan 4, 2019 · 1 comment
Open

Dot segments from path not removed #27929

ghost opened this issue Jan 4, 2019 · 1 comment
Labels
area: router freq1: low P5 The team acknowledges the request but does not plan to address it, it remains open for discussion router: URL parsing/generation state: confirmed type: bug/fix
Milestone
Backlog

Comments

@ghost
Copy link

ghost commented Jan 4, 2019 •
edited by ghost

馃悶 bug report

Affected Package

@angular/router

Is this a regression?

No

Description

By RFC3986 (https://tools.ietf.org/html/rfc3986#page-33) dot segments should be removed from path.

When accessing localhost:4200/segment/./segment by browser navigator, browser strips the dot segments and Angular router recieves localhost:4200/segment/segment. Everything works as expected.

When programmatically routing to './segment/./segment', Angular throws an error (404).
Browser navigator still shows URI with dot segments stripped (localhost:4200/segment/segment).

馃敩 Minimal Reproduction

https://stackblitz.com/edit/angular-d2kk5q?file=src%2Findex.html

馃敟 Exception or Error

Cannot match any routes. URL Segment: 'segment/./segment'

馃實 Your Environment

Angular Version:
7.0.1

Extra

I'm not sure if I would call this a bug, but it's definitely not consistent with browser routes.
@ngbot ngbot bot added this to the needsTriage milestone Jan 4, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jan 15, 2019
@jelbourn jelbourn added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed type: use-case severity3: broken labels Oct 1, 2020
@dylhunn
Copy link
Contributor

dylhunn commented Jul 11, 2022 •
edited

Due to lack of interest in the relatively esoteric case, we will likely not make any changes.

Edit: we would consider accepting a PR though.

@dylhunn dylhunn closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2022
@dylhunn dylhunn reopened this Jul 11, 2022
@dylhunn dylhunn added P5 The team acknowledges the request but does not plan to address it, it remains open for discussion and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: router freq1: low P5 The team acknowledges the request but does not plan to address it, it remains open for discussion router: URL parsing/generation state: confirmed type: bug/fix
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@atscott @jasonaden @jelbourn @kara @dylhunn