ci: move the remaining travis tests to circle #27937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 227c52e at https://pr27937-227c52e.ngbuilds.io/. |
IgorMinar
commented
Jan 4, 2019
IgorMinar
commented
Jan 4, 2019
kara
added
the
area: build & ci
|
You can preview d112645 at https://pr27937-d112645.ngbuilds.io/. |
|
You can preview 74b5bc7 at https://pr27937-74b5bc7.ngbuilds.io/. |
|
You can preview 84ce92e at https://pr27937-84ce92e.ngbuilds.io/. |
|
You can preview 50280d5 at https://pr27937-50280d5.ngbuilds.io/. |
|
You can preview 4c868cb at https://pr27937-4c868cb.ngbuilds.io/. |
|
You can preview 23320fc at https://pr27937-23320fc.ngbuilds.io/. |
|
You can preview 5e5db78 at https://pr27937-5e5db78.ngbuilds.io/. |
|
You can preview cbd3a3d at https://pr27937-cbd3a3d.ngbuilds.io/. |
|
You can preview bf9e746 at https://pr27937-bf9e746.ngbuilds.io/. |
|
You can preview 0c566fc at https://pr27937-0c566fc.ngbuilds.io/. |
|
You can preview 9d78561 at https://pr27937-9d78561.ngbuilds.io/. |
|
You can preview ee9f0e0 at https://pr27937-ee9f0e0.ngbuilds.io/. |
|
You can preview 5aab8e4 at https://pr27937-5aab8e4.ngbuilds.io/. |
devversion
force-pushed
the
ci/travis-thanks-for-all-the-fish
branch
from
5aab8e4
to
f026b19
Compare
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
You can preview f026b19 at https://pr27937-f026b19.ngbuilds.io/. |
|
You can preview 969199f at https://pr27937-969199f.ngbuilds.io/. |
|
You can preview df5edde at https://pr27937-df5edde.ngbuilds.io/. |
|
You can preview fcda67b at https://pr27937-fcda67b.ngbuilds.io/. |
|
You can preview 39557e7 at https://pr27937-39557e7.ngbuilds.io/. |
|
You can preview 9e9d4fa at https://pr27937-9e9d4fa.ngbuilds.io/. |
devversion
added a commit
to devversion/angular
that referenced
this pull request
Jan 9, 2019
devversion
added a commit
to devversion/angular
that referenced
this pull request
Jan 9, 2019
…ar#27937) * Groups the two sharded `test_docs_examples` job using CircleCI's `parallelism` feature. This makes the amount of jobs that show up on a PR, more reduced and also reduces code duplication for maintaining the Circle job definition. PR Close angular#27937
devversion
added a commit
to devversion/angular
that referenced
this pull request
Jan 9, 2019
|
We can't remove ngcontainer yet. I talked to AlexE. Too many other repos
need it.
…On Sat, Jan 12, 2019, 1:38 PM Paul Gschwendtner ***@***.*** wrote:
***@***.**** commented on this pull request.
------------------------------
In .circleci/config.yml
<#27937 (comment)>:
> @@ -462,3 +513,9 @@ workflows:
branches:
only:
- master
+
+# TODO:
+# - don't build the g3 branch
+# - verify that we are bootstrapping with the right yarn version coming from the docker image
+# - check local chrome version pulled from docker image
+# - remove /tools/ngcontainer
@gkalpak <https://github.com/gkalpak> No problem 😄 I'm currently not
working on these, nor we have these tracked anywhere yet (except in this
file).
Agreed, I think it would be good to move these to JIRA. I personally would
like to be involved with the removal of ngcontainer since we still use it
on Material and I've been trying to remove it already in #26691
<#26691>. If you create one, can
you mention that Material still depends on it atm?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27937 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AANM6FQmBkpSU-HJgUJkCq6e2Ukg_65Eks5vClXngaJpZM4ZskeU>
.
|
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
Moving the tests over to CircleCI in pretty much "as-is" state just so that we can drop the dependency on Travis. In the followup changes we plan to migrate these tests to run on sauce under bazel. @gregmagolan is working on that. I've previously verified that all the tests executed in legacy-unit-tests-local already under bazel. Therefore the legacy-unit-tests-local job is strictly not necessary any more, but given how flaky legacy-unit-tests-saucelabs is, it is good to have the -local job just so that we can quickly determine if any failure is a flake or legit issue (the bazel version of these tests could theoretically run in a slightly different way and fail or not fail in a different way, so having -lcoal job is just an extra safety check). This change was coauthored with @devversion PR Close #27937
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
the metadata build seems to be needed only by the offline compiler tests which is currently disabled PR Close #27937
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
we no longer need it... yay!!! PR Close #27937
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
test.sh is no longer needed... all the tests should now be executed via bazel. if for whatever reason we need to run the legacy unit test setup, we should should follow the commands that we use to execute those tests in .circle/config.yaml PR Close #27937
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
this script is now obsolete and not needed any more. yay!!! PR Close #27937
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
…ode devDep (#27937) I'm not sure why this problem is visible only now or how this worked before, but the CI is now failing because @types/node is missing. I also added the yarn.lock file which was previously omitted. We want the yarn.lock file in so that our deps don't change over time without us knowing. PR Close #27937
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
* Groups the two sharded `test_docs_examples` job using CircleCI's `parallelism` feature. This makes the amount of jobs that show up on a PR, more reduced and also reduces code duplication for maintaining the Circle job definition. PR Close #27937
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
Moving the tests over to CircleCI in pretty much "as-is" state just so that we can drop the dependency on Travis. In the followup changes we plan to migrate these tests to run on sauce under bazel. @gregmagolan is working on that. I've previously verified that all the tests executed in legacy-unit-tests-local already under bazel. Therefore the legacy-unit-tests-local job is strictly not necessary any more, but given how flaky legacy-unit-tests-saucelabs is, it is good to have the -local job just so that we can quickly determine if any failure is a flake or legit issue (the bazel version of these tests could theoretically run in a slightly different way and fail or not fail in a different way, so having -lcoal job is just an extra safety check). This change was coauthored with @devversion PR Close angular#27937
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
the metadata build seems to be needed only by the offline compiler tests which is currently disabled PR Close angular#27937
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
we no longer need it... yay!!! PR Close angular#27937
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
test.sh is no longer needed... all the tests should now be executed via bazel. if for whatever reason we need to run the legacy unit test setup, we should should follow the commands that we use to execute those tests in .circle/config.yaml PR Close angular#27937
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
this script is now obsolete and not needed any more. yay!!! PR Close angular#27937
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…ode devDep (angular#27937) I'm not sure why this problem is visible only now or how this worked before, but the CI is now failing because @types/node is missing. I also added the yarn.lock file which was previously omitted. We want the yarn.lock file in so that our deps don't change over time without us knowing. PR Close angular#27937
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…ar#27937) * Groups the two sharded `test_docs_examples` job using CircleCI's `parallelism` feature. This makes the amount of jobs that show up on a PR, more reduced and also reduces code duplication for maintaining the Circle job definition. PR Close angular#27937
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last chunk of work to move us off of Travis.
Huge thanks to @devversion for helping me work through this PR.