Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ivy): root causes update for 'platform-browser-dynamic' and i18n tests #27972

Closed
wants to merge 2 commits into from
Closed

test(ivy): root causes update for 'platform-browser-dynamic' and i18n tests #27972

wants to merge 2 commits into from

Conversation

AndrewKushnir
Copy link
Contributor

Updated root cause for one tests and enabled 2 tests that are now passing.

PR Type

What kind of change does this PR introduce?

  • Other... Please describe: TestBed issues root causes update

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Jan 8, 2019
@AndrewKushnir AndrewKushnir requested a review from a team as a code owner January 8, 2019 01:30
@ngbot ngbot bot added this to the needsTriage milestone Jan 8, 2019
@mary-poppins
Copy link

You can preview 04df4d1 at https://pr27972-04df4d1.ngbuilds.io/.

@kara kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 8, 2019
@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 8, 2019
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 8, 2019
@mary-poppins
Copy link

You can preview 35f638d at https://pr27972-35f638d.ngbuilds.io/.

@AndrewKushnir AndrewKushnir assigned kara and unassigned AndrewKushnir Jan 8, 2019
kara
kara approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 8, 2019
@kara kara removed their assignment Jan 8, 2019
@kara kara added the action: merge The PR is ready for merge by the caretaker label Jan 8, 2019
@ngbot
Copy link

ngbot bot commented Jan 8, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: legacy-e2e-tests" is failing
    pending status "ci/circleci: integration_test" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@kara kara closed this in f547110 Jan 8, 2019
devversion pushed a commit to devversion/angular that referenced this pull request Jan 9, 2019
@AndrewKushnir @devversion
test(ivy): root causes update for 'platform-browser-dynamic' and i18n…
0212b42 
… tests (angular#27972)

PR Close angular#27972
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@AndrewKushnir @ngfelixl
test(ivy): root causes update for 'platform-browser-dynamic' and i18n…
1bc3c91 
… tests (angular#27972)

PR Close angular#27972
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndrewKushnir @mary-poppins @kara @googlebot