refactor(bazel): use web_package rule for index.html #27995
Conversation
|
You can preview bb1c137 at https://pr27995-bb1c137.ngbuilds.io/. |
|
You can preview dc5961c at https://pr27995-dc5961c.ngbuilds.io/. |
kara
added
the
area: bazel
There was a problem hiding this comment.
can you also add more context into the commit message explaining why you are making this change and how is web_package rule better than the current approach?
the CI is failing (sauce failure is a flake, but the other one seems legit - please fix)
the rest looks good to me. please clean up and label for merge. thanks
IgorMinar
added
action: cleanup
|
This PR is currently blocked pending #28000 |
|
Sgtm
…On Tue, Jan 8, 2019, 6:28 PM Keen Yee Liau ***@***.*** wrote:
This PR is currently blocked pending #28000
<#28000>
Will address the comments along with the rebase once the PR is merged.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#27995 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANM6GmpWACFtqlLdyul9oVP2ev8tQ6Gks5vBVPIgaJpZM4Z2MHr>
.
|
kyliau
force-pushed
the
web_package
branch
2 times, most recently
from
852c5fa
to
04abbbe
Compare
|
You can preview 852c5fa at https://pr27995-852c5fa.ngbuilds.io/. |
|
You can preview 04abbbe at https://pr27995-04abbbe.ngbuilds.io/. |
|
You can preview 49f45f5 at https://pr27995-49f45f5.ngbuilds.io/. |
|
You can preview 2f5f5ef at https://pr27995-2f5f5ef.ngbuilds.io/. |
|
You can preview 3b53aae at https://pr27995-3b53aae.ngbuilds.io/. |
|
You can preview 6b7718e at https://pr27995-6b7718e.ngbuilds.io/. |
|
You can preview c8673ef at https://pr27995-c8673ef.ngbuilds.io/. |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
CLAs look good, thanks! |
|
You can preview cd6caaa at https://pr27995-cd6caaa.ngbuilds.io/. |
|
You can preview 6ee3918 at https://pr27995-6ee3918.ngbuilds.io/. |
|
You can preview 761a702 at https://pr27995-761a702.ngbuilds.io/. |
|
You can preview d198025 at https://pr27995-d198025.ngbuilds.io/. |
index.html needs to have the zone.js and the project bundle injected using script tags. This used to be done explicitly by specifying a new index.html but with `web_package` rule introduced in rules_nodejs, it is now possible to perform the injection dynamically.
kyliau
removed
action: cleanup
|
You can preview de8bfcb at https://pr27995-de8bfcb.ngbuilds.io/. |
index.html needs to have the zone.js and the project bundle injected using script tags. This used to be done explicitly by specifying a new index.html but with `web_package` rule introduced in rules_nodejs, it is now possible to perform the injection dynamically. PR Close #27995
index.html needs to have the zone.js and the project bundle injected using script tags. This used to be done explicitly by specifying a new index.html but with `web_package` rule introduced in rules_nodejs, it is now possible to perform the injection dynamically. PR Close angular#27995
index.html needs to have the zone.js and the project bundle injected using script tags. This used to be done explicitly by specifying a new index.html but with `web_package` rule introduced in rules_nodejs, it is now possible to perform the injection dynamically. PR Close #27995
index.html needs to have the zone.js and the project bundle injected using script tags. This used to be done explicitly by specifying a new index.html but with `web_package` rule introduced in rules_nodejs, it is now possible to perform the injection dynamically. PR Close angular#27995
index.html needs to have the zone.js and the project bundle injected using script tags. This used to be done explicitly by specifying a new index.html but with `web_package` rule introduced in rules_nodejs, it is now possible to perform the injection dynamically. PR Close angular#27995
index.html needs to have the zone.js and the project bundle injected using script tags. This used to be done explicitly by specifying a new index.html but with `web_package` rule introduced in rules_nodejs, it is now possible to perform the injection dynamically. PR Close angular#27995
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
index.html needs to have the zone.js and the project bundle injected
using script tags. This used to be done explicitly by specifying a
new index.html but with
web_packagerule introduced in rules_nodejs,it is now possible to perform the injection dynamically.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information