Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ivy): updating root causes for tests within @angular/core #28003

Closed
wants to merge 1 commit into from
Closed

test(ivy): updating root causes for tests within @angular/core #28003

wants to merge 1 commit into from

Conversation

AndrewKushnir
Copy link
Contributor

The problem that fixmeIvys refer to is resolved, but the tests are still broken due to other issue (not possible to retrieve host property bindings for DebugElement).

PR Type

What kind of change does this PR introduce?

  • Other... Please describe: root causes update for issues within @angular/core package tests.

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir
test(ivy): updating root causes for tests within @angular/core
baf1613 
The problem that `fixmeIvy`s refer to is resolved, but the tests are still broken due to other issue (not possible to retrieve host property bindings for DebugElement).
@AndrewKushnir AndrewKushnir requested a review from a team as a code owner January 9, 2019 02:07
@AndrewKushnir AndrewKushnir added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Jan 9, 2019
@ngbot ngbot bot modified the milestone: needsTriage Jan 9, 2019
@mary-poppins
Copy link

You can preview baf1613 at https://pr28003-baf1613.ngbuilds.io/.

kara
kara approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 9, 2019
@AndrewKushnir AndrewKushnir added the action: merge The PR is ready for merge by the caretaker label Jan 9, 2019
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@AndrewKushnir @ngfelixl
test(ivy): updating root causes for tests within @angular/core (angul…
c354e88 
…ar#28003)

The problem that `fixmeIvy`s refer to is resolved, but the tests are still broken due to other issue (not possible to retrieve host property bindings for DebugElement).

PR Close angular#28003
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndrewKushnir @mary-poppins @kara @googlebot