Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to and resolution of root cause failures in core animation tests #28026

Closed
wants to merge 4 commits into from
Closed

Fixes to and resolution of root cause failures in core animation tests #28026

wants to merge 4 commits into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Jan 9, 2019

No description provided.

@matsko matsko requested review from a team as code owners January 9, 2019 21:42
@mary-poppins
Copy link

You can preview 7c1076f at https://pr28026-7c1076f.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 5561b5b at https://pr28026-5561b5b.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 24d5024 at https://pr28026-24d5024.ngbuilds.io/.

@matsko matsko added the target: major This PR is targeted for the next major release label Jan 9, 2019
kara
kara requested changes Jan 9, 2019
View reviewed changes
packages/core/test/animation/animation_integration_spec.ts Outdated Show resolved Hide resolved
packages/compiler/src/render3/view/template.ts
// setProperty without a value doesn't make any sense
if (value.name || value.value) {
const bindingName = prepareSyntheticPropertyName(input.name);
const hasValue = value && (value instanceof LiteralPrimitive) ? !!value.value : true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here to explain this check?

@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews comp: ivy labels Jan 9, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 9, 2019
@mary-poppins
Copy link

You can preview a7de6cf at https://pr28026-a7de6cf.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 184f500 at https://pr28026-184f500.ngbuilds.io/.

kara
kara approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 9, 2019
@mary-poppins
Copy link

You can preview 815b842 at https://pr28026-815b842.ngbuilds.io/.

@matsko
Copy link
Contributor Author

matsko commented Jan 9, 2019

https://tap.corp.google.com/ui#id=OCL:228588746:BASE:228598338:1547075921206:5babac25

@AndrewKushnir
Copy link
Contributor

@matsko new g3 presubmit (the old one has conflicts, since the g3 sync CL just landed):
http://test/OCL:228600272:BASE:228600324:1547076679434:fdf70e06

@matsko
Copy link
Contributor Author

matsko commented Jan 9, 2019

Thank you @AndrewKushnir

@matsko matsko added the action: merge The PR is ready for merge by the caretaker label Jan 10, 2019
AndrewKushnir pushed a commit that referenced this pull request Jan 10, 2019
@matsko @AndrewKushnir
fix(ivy): ensure animation @bindings work for {key:value} and empty b…
94c0b7a 
…indings (#28026)

PR Close #28026
@matsko matsko deleted the core_animation_test_fixes branch January 17, 2019 19:41
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@matsko @ngfelixl
test(ivy): update root causes for animation tests (angular#28026)
0a6a461 
PR Close angular#28026
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@matsko @ngfelixl
fix(ivy): ensure animation @bindings work for {key:value} and empty b…
3e4fcf7 
…indings (angular#28026)

PR Close angular#28026
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@matsko @mary-poppins @AndrewKushnir @mhevery @kara @googlebot