New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add ng-India to events list #28119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you, please, change the commit message to docs: add ng-India to events list
?
Hi @StephenFluin, can you please review this? thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to add the 2019 event, but let's leave out the 2018 dates. We're going to be cleaning up "past events" soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed past event details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs: add ng-India to events list
Hi @StephenFluin, I've removed the past event details, please review this. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny change and then you'll need to squash your commits.
https://twitter.com/stephenfluin/status/1009904095073718275?lang=en
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
docs: add ng-India to events list
c0f6929
to
6fd47b7
Compare
CLAs look good, thanks! |
thanks @StephenFluin, not sure why the tests failed! |
merge-assistance: saucelabs flake |
docs: add ng-India to events list PR Close #28119
docs: add ng-India to events list PR Close angular#28119
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
docs(docs-infra): add ng-India to events list on angular.io/events
added "ng-India" to the events list on angular.io/events
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information