Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add ng-India to events list #28119

Closed
wants to merge 1 commit into from

Conversation

debugmodedotnet
Copy link
Contributor

@debugmodedotnet debugmodedotnet commented Jan 14, 2019

docs(docs-infra): add ng-India to events list on angular.io/events

added "ng-India" to the events list on angular.io/events

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@debugmodedotnet debugmodedotnet requested a review from a team as a code owner January 14, 2019 06:32
@gkalpak gkalpak added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 14, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 14, 2019
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you, please, change the commit message to docs: add ng-India to events list?

@gkalpak gkalpak changed the title docs(docs-infra): add ng-India to events list docs: add ng-India to events list Jan 14, 2019
@brandonroberts brandonroberts added feature Issue that requests a new feature effort1: hours risk: low labels Jan 14, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jan 14, 2019
@debugmodedotnet
Copy link
Contributor Author

Hi @StephenFluin, can you please review this? thanks.

Copy link
Contributor

@StephenFluin StephenFluin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to add the 2019 event, but let's leave out the 2018 dates. We're going to be cleaning up "past events" soon.

Copy link
Contributor Author

@debugmodedotnet debugmodedotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed past event details

Copy link
Contributor Author

@debugmodedotnet debugmodedotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: add ng-India to events list

@debugmodedotnet
Copy link
Contributor Author

Hi @StephenFluin, I've removed the past event details, please review this. thanks!

Copy link
Contributor

@StephenFluin StephenFluin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change and then you'll need to squash your commits.
https://twitter.com/stephenfluin/status/1009904095073718275?lang=en

aio/content/marketing/events.html Outdated Show resolved Hide resolved
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

docs: add ng-India to events list
@googlebot
Copy link

CLAs look good, thanks!

@debugmodedotnet
Copy link
Contributor Author

thanks @StephenFluin, not sure why the tests failed!

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 27, 2019
@IgorMinar
Copy link
Contributor

merge-assistance: saucelabs flake

@ngbot
Copy link

ngbot bot commented Jan 27, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: legacy-unit-tests-saucelabs" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jasonaden jasonaden closed this in 8e75a40 Jan 29, 2019
jasonaden pushed a commit that referenced this pull request Jan 29, 2019
docs: add ng-India to events list
PR Close #28119
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours feature Issue that requests a new feature merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants