Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(language-service): Cleanup ts_plugin #28145

Closed
wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Jan 15, 2019

This commit removes the unnecessary typescriptOnly() helper from
ts_plugin and all unused methods related to that.

This is the first step towards migrating the language service to be a plugin.
It allows Angular language service to better keep track of upstream tsserver API changes.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This commit removes the unnecessary typescriptOnly() helper from
ts_plugin and all unused methods related to that.
@kyliau kyliau added state: WIP area: language-service Issues related to Angular's VS Code language service target: major This PR is targeted for the next major release labels Jan 15, 2019
@kyliau kyliau requested a review from a team as a code owner January 15, 2019 01:18
@ngbot ngbot bot added this to the needsTriage milestone Jan 15, 2019
@mary-poppins
Copy link

You can preview 69d56ee at https://pr28145-69d56ee.ngbuilds.io/.

@kyliau kyliau removed the state: WIP label Jan 15, 2019
@vikerman vikerman self-requested a review January 15, 2019 19:21
@kyliau kyliau added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jan 15, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Jan 15, 2019
@kyliau
Copy link
Contributor Author

kyliau commented Jan 15, 2019

caretaker: PR was approved but pullapprove status was not updated.

@kyliau kyliau deleted the nglangsvc branch January 15, 2019 20:04
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 18, 2019
This commit removes the unnecessary typescriptOnly() helper from
ts_plugin and all unused methods related to that.

PR Close angular#28145
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 18, 2019
This commit removes the unnecessary typescriptOnly() helper from
ts_plugin and all unused methods related to that.

PR Close angular#28145
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
This commit removes the unnecessary typescriptOnly() helper from
ts_plugin and all unused methods related to that.

PR Close angular#28145
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants