New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(language-service): Cleanup ts_plugin #28145
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the unnecessary typescriptOnly() helper from ts_plugin and all unused methods related to that.
kyliau
added
state: WIP
area: language-service
Issues related to Angular's VS Code language service
target: major
This PR is targeted for the next major release
labels
Jan 15, 2019
You can preview 69d56ee at https://pr28145-69d56ee.ngbuilds.io/. |
vikerman
approved these changes
Jan 15, 2019
kyliau
added
the
merge: caretaker note
Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
label
Jan 15, 2019
caretaker: PR was approved but pullapprove status was not updated. |
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Jan 18, 2019
This commit removes the unnecessary typescriptOnly() helper from ts_plugin and all unused methods related to that. PR Close angular#28145
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Jan 18, 2019
This commit removes the unnecessary typescriptOnly() helper from ts_plugin and all unused methods related to that. PR Close angular#28145
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
This commit removes the unnecessary typescriptOnly() helper from ts_plugin and all unused methods related to that. PR Close angular#28145
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: language-service
Issues related to Angular's VS Code language service
cla: yes
merge: caretaker note
Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the unnecessary typescriptOnly() helper from
ts_plugin and all unused methods related to that.
This is the first step towards migrating the language service to be a plugin.
It allows Angular language service to better keep track of upstream
tsserver
API changes.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information