Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deployment guide with serve-from-disk info from CLI story #28217

Closed
wants to merge 1 commit into from
Closed

Update deployment guide with serve-from-disk info from CLI story #28217

wants to merge 1 commit into from

Conversation

jbogarthyde
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Re-organized page to position serve-from-disk instructions (from wiki CLI Story page) as deployment testing in early stages of deployment. Moved section beginning from end of doc, edited to include more of the story content.

@jbogarthyde jbogarthyde requested a review from a team as a code owner January 17, 2019 23:25
@jbogarthyde jbogarthyde added type: bug/fix comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer effort1: hours aio: preview target: patch This PR is targeted for the next patch release labels Jan 17, 2019
@ngbot ngbot bot modified the milestone: needsTriage Jan 17, 2019
@mary-poppins
Copy link

You can preview 7920d6f at https://pr28217-7920d6f.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 317e59d at https://pr28217-317e59d.ngbuilds.io/.

@mary-poppins
Copy link

You can preview b03a4ca at https://pr28217-b03a4ca.ngbuilds.io/.

@jbogarthyde jbogarthyde force-pushed the jb-deploy-update branch 2 times, most recently from 4ed72c5 to 6080b9a Compare January 18, 2019 19:15
@mary-poppins
Copy link

You can preview 4ed72c5 at https://pr28217-4ed72c5.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 6080b9a at https://pr28217-6080b9a.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 650a211 at https://pr28217-650a211.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 1fb1ede at https://pr28217-1fb1ede.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 578849f at https://pr28217-578849f.ngbuilds.io/.

@hansl
Copy link
Contributor

hansl commented Jan 24, 2019

@alexeagle @IgorMinar You are both on the fw-docs-packaging team which is blocking this PR. Can you review?

@mary-poppins
Copy link

You can preview bc97039 at https://pr28217-bc97039.ngbuilds.io/.

@mary-poppins
Copy link

You can preview da086d4 at https://pr28217-da086d4.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 9502939 at https://pr28217-9502939.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 053c4cf at https://pr28217-053c4cf.ngbuilds.io/.

@mary-poppins
Copy link

You can preview cb5e052 at https://pr28217-cb5e052.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 83ba957 at https://pr28217-83ba957.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 7ce992f at https://pr28217-7ce992f.ngbuilds.io/.

@jbogarthyde jbogarthyde force-pushed the jb-deploy-update branch 2 times, most recently from b950a0b to 731378c Compare March 27, 2019 16:37
@mary-poppins
Copy link

You can preview b950a0b at https://pr28217-b950a0b.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 731378c at https://pr28217-731378c.ngbuilds.io/.

@mary-poppins
Copy link

You can preview ca186eb at https://pr28217-ca186eb.ngbuilds.io/.

@jbogarthyde jbogarthyde removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 28, 2019
@jbogarthyde jbogarthyde removed the request for review from jenniferfell March 28, 2019 17:43
@jbogarthyde jbogarthyde added the action: merge The PR is ready for merge by the caretaker label Mar 28, 2019
jasonaden pushed a commit that referenced this pull request Mar 28, 2019
@jbogarthyde @jasonaden
docs: reorg deployment guide with serve-from-disk info from CLI story (…
baec8ab 
…#28217)

PR Close #28217
@jasonaden jasonaden closed this in 27ba4ac Mar 28, 2019
@jbogarthyde jbogarthyde deleted the jb-deploy-update branch April 1, 2019 15:54
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@jbogarthyde @wKoza
docs: reorg deployment guide with serve-from-disk info from CLI story (…
c5bb708 
…angular#28217)

PR Close angular#28217
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@hansl hansl hansl approved these changes

Assignees

@jenniferfell jenniferfell

Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort1: hours target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jbogarthyde @mary-poppins @hansl @alexeagle @googlebot @jenniferfell