Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): increase node memory limit for ng_module rule to prevent OOM for big modules #28237

Closed

Conversation

IgorMinar
Copy link
Contributor

This came up as a request from an internal Google team.

Context:

…OOM for big modules

This came up as a request from an internal Google team.

Context:
- http://cl/229881085
- https://groups.google.com/a/google.com/forum/#!topic/nodejs/GLqDEOW0MV4
@IgorMinar IgorMinar requested a review from a team as a code owner January 18, 2019 15:50
@IgorMinar IgorMinar added target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules labels Jan 18, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 18, 2019
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Jan 18, 2019
@mary-poppins
Copy link

You can preview 9f817f6 at https://pr28237-9f817f6.ngbuilds.io/.

@alxhub alxhub closed this in 73616ab Jan 18, 2019
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
…OOM for big modules (angular#28237)

This came up as a request from an internal Google team.

Context:
- http://cl/229881085
- https://groups.google.com/a/google.com/forum/#!topic/nodejs/GLqDEOW0MV4

PR Close angular#28237
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants