Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo for Browserslist in file structure guide #28312

Closed
wants to merge 1 commit into from
Closed

docs: fix typo for Browserslist in file structure guide #28312

wants to merge 1 commit into from

Conversation

MattiJarvinen
Copy link

Filename browserlist is actually browserslist

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #28311

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Documentation typo fix.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@MattiJarvinen
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

jithil-kore added a commit to MrJithil/angular that referenced this pull request Jan 24, 2019
jithil-kore added a commit to MrJithil/angular that referenced this pull request Jan 24, 2019
jithil-kore added a commit to MrJithil/angular that referenced this pull request Jan 24, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 24, 2019
@brandonroberts brandonroberts added effort1: hours action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR subtype: docs-edit type: bug/fix labels Jan 24, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jan 24, 2019
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update git commit message to docs: fix typo for Browserslist in file structure guide

@brandonroberts brandonroberts added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 24, 2019
@brandonroberts brandonroberts self-assigned this Jan 24, 2019
@brandonroberts brandonroberts changed the title docs: fix typo docs: fix typo for Browserslist in file structure guide Jan 24, 2019
@MattiJarvinen
Copy link
Author

@brandonroberts actually noticed another Browserlist mention in the file and fixed it too, also updated commit message.

@brandonroberts brandonroberts removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 25, 2019
@brandonroberts
Copy link
Contributor

Caretaker note: This is a docs-only change and I'm using a global approval.

@MattiJarvinen
Copy link
Author

MattiJarvinen commented Jan 25, 2019

@IgorMinar & @brandonroberts just occurred to me my CLA is with my real email address and my commit is on Github no-reply, do I have to amend it to the real address or not?

@brandonroberts
Copy link
Contributor

@MattiJarvinen-BA Igor can correct me, but I believe the CLA bot uses your provided GitHub email to confirm that you've signed the CLA. So even if you just create a pull request using the pencil on any page, its still tied to the email on your GitHub account.

@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jan 29, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Jan 29, 2019
@jasonaden jasonaden closed this in 24f5428 Jan 30, 2019
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants