Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): queries should register matches from top to bottom #28319

Closed
wants to merge 2 commits into from
Closed

fix(ivy): queries should register matches from top to bottom #28319

wants to merge 2 commits into from

Conversation

marclaval
Copy link
Contributor

@marclaval marclaval commented Jan 23, 2019 •
edited

This PR fixes FW-781.

In order to have the right order in queries' results, the matching is moved from elementEnd()/elementContainerEnd() to elementStart()/elementContainerStart().

Edit: both unit tests currently return `['A', 'D', 'C, 'B', 'E'] without this fix.

@marclaval marclaval requested a review from a team as a code owner January 23, 2019 16:00
@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Jan 23, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 23, 2019
@mhevery mhevery self-assigned this Jan 23, 2019
pkozlowski-opensource
pkozlowski-opensource approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that we are moving reporting nodes to queries from the elementEnd to the elementStart and this makes sense. LGTM

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 23, 2019
@pkozlowski-opensource
Copy link
Member

merge-assistance as it needs G3 presubmit

kara
kara requested changes Jan 23, 2019
View reviewed changes
packages/core/test/render3/query_spec.ts Outdated Show resolved Hide resolved
@kara kara removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 23, 2019
@mhevery
Copy link
Contributor

mhevery commented Jan 23, 2019

http://test/OCL:230603306:BASE:230603362:1548282434939:792871b1

@marclaval marclaval added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 24, 2019
kara
kara approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 25, 2019
@jasonaden jasonaden closed this in fdc2b0b Jan 25, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 26, 2019
@marclaval @wKoza
fix(ivy): queries should register matches from top to bottom (angular…
eac6377 
…#28319)

PR Close angular#28319
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 26, 2019
@marclaval @wKoza
fix(ivy): queries should register matches from top to bottom (angular…
299597b 
…#28319)

PR Close angular#28319
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
@marclaval @vetom
fix(ivy): queries should register matches from top to bottom (angular…
3ecd718 
…#28319)

PR Close angular#28319
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marclaval @pkozlowski-opensource @mhevery @kara @googlebot