Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ivy): clean up TNode not depending on LView #28354

Closed
wants to merge 3 commits into from
Closed

refactor(ivy): clean up TNode not depending on LView #28354

wants to merge 3 commits into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Jan 24, 2019

No description provided.

@mhevery mhevery requested a review from kara January 24, 2019 23:50
@mhevery mhevery requested a review from a team as a code owner January 24, 2019 23:50
@mhevery mhevery added the target: major This PR is targeted for the next major release label Jan 24, 2019
kara
kara approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from formatting error

packages/core/src/render3/instructions.ts Outdated Show resolved Hide resolved
@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews comp: ivy labels Jan 25, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 25, 2019
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 25, 2019
@mhevery
Copy link
Contributor Author

mhevery commented Jan 25, 2019

http://test/OCL:230947026:BASE:230947079:1548447617322:7c2a4887

@jasonaden jasonaden closed this in 3d5a919 Jan 25, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 26, 2019
@mhevery @wKoza
refactor(ivy): clean up TNode not depending on LView (angular#28354)
2acaaf0 
PR Close angular#28354
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 26, 2019
@mhevery @wKoza
refactor(ivy): clean up TNode not depending on LView (angular#28354)
5222469 
PR Close angular#28354
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
@mhevery @vetom
refactor(ivy): clean up TNode not depending on LView (angular#28354)
1a84196 
PR Close angular#28354
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource left review comments

@benlesh benlesh benlesh approved these changes

@kara kara kara approved these changes

Assignees

@mhevery mhevery

Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mhevery @pkozlowski-opensource @benlesh @kara @googlebot