Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ivy): support property bindings and interpolations in DebugElement #28355

Closed
wants to merge 4 commits into from
Closed

feat(ivy): support property bindings and interpolations in DebugElement #28355

wants to merge 4 commits into from

Conversation

kara
Copy link
Contributor

@kara kara commented Jan 25, 2019

DebugElement.properties should contain a map of element
property names to element property values, with entries
for both normal property bindings and host bindings.
Many Angular core tests depend on this map being present.

This PR adds support for host property bindings, normal property
bindings, and interpolations in DebugElement.properties, which
fixes the Angular core tests.

@kara
feat(ivy): support host properties in DebugElement.properties
1536906 
DebugElement.properties should contain a map of element
property names to element property values, with entries
for both normal property bindings and host bindings.
Many Angular core tests depend on this map being present.

This commit adds support for host property bindings in
DebugElement.properties, which fixes the Angular core tests.
There is still work to be done for normal property bindings.
@kara kara requested a review from a team as a code owner January 25, 2019 01:16
@kara
feat(ivy): support property bindings and interpolations in DebugElement
fb11363 
DebugElement.properties should contain a map of element
property names to element property values, with entries
for both normal property bindings and host bindings.

This commit adds support for property bindings in
DebugElement.properties (including interpolations).
@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Jan 25, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 25, 2019
mhevery
mhevery approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With clanup.

packages/core/src/render3/instructions.ts Show resolved Hide resolved
packages/core/src/render3/util.ts Outdated Show resolved Hide resolved
@mhevery mhevery added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 25, 2019
@kara kara removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 25, 2019
@kara
Copy link
Contributor Author

kara commented Jan 25, 2019

presubmit

jelbourn
jelbourn reviewed Jan 25, 2019
View reviewed changes
packages/core/src/debug/debug_node.ts Outdated Show resolved Hide resolved
packages/core/src/debug/debug_node.ts Outdated Show resolved Hide resolved
packages/core/src/render3/util.ts Show resolved Hide resolved
@kara kara added the action: merge The PR is ready for merge by the caretaker label Jan 25, 2019
@jasonaden jasonaden closed this in 46aec4a Jan 25, 2019
jasonaden pushed a commit that referenced this pull request Jan 25, 2019
@kara @jasonaden
feat(ivy): support property bindings and interpolations in DebugEleme…
bf97d3b 
…nt (#28355)

DebugElement.properties should contain a map of element
property names to element property values, with entries
for both normal property bindings and host bindings.

This commit adds support for property bindings in
DebugElement.properties (including interpolations).

PR Close #28355
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 26, 2019
@kara @wKoza
feat(ivy): support host properties in DebugElement.properties (angula…
15d7652 
…r#28355)

DebugElement.properties should contain a map of element
property names to element property values, with entries
for both normal property bindings and host bindings.
Many Angular core tests depend on this map being present.

This commit adds support for host property bindings in
DebugElement.properties, which fixes the Angular core tests.
There is still work to be done for normal property bindings.

PR Close angular#28355
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 26, 2019
@kara @wKoza
feat(ivy): support property bindings and interpolations in DebugEleme…
39c0118 
…nt (angular#28355)

DebugElement.properties should contain a map of element
property names to element property values, with entries
for both normal property bindings and host bindings.

This commit adds support for property bindings in
DebugElement.properties (including interpolations).

PR Close angular#28355
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 26, 2019
@kara @wKoza
feat(ivy): support host properties in DebugElement.properties (angula…
35309fa 
…r#28355)

DebugElement.properties should contain a map of element
property names to element property values, with entries
for both normal property bindings and host bindings.
Many Angular core tests depend on this map being present.

This commit adds support for host property bindings in
DebugElement.properties, which fixes the Angular core tests.
There is still work to be done for normal property bindings.

PR Close angular#28355
wKoza pushed a commit to wKoza/angular that referenced this pull request Jan 26, 2019
@kara @wKoza
feat(ivy): support property bindings and interpolations in DebugEleme…
521dc1c 
…nt (angular#28355)

DebugElement.properties should contain a map of element
property names to element property values, with entries
for both normal property bindings and host bindings.

This commit adds support for property bindings in
DebugElement.properties (including interpolations).

PR Close angular#28355
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
@kara @vetom
feat(ivy): support host properties in DebugElement.properties (angula…
e250dcb 
…r#28355)

DebugElement.properties should contain a map of element
property names to element property values, with entries
for both normal property bindings and host bindings.
Many Angular core tests depend on this map being present.

This commit adds support for host property bindings in
DebugElement.properties, which fixes the Angular core tests.
There is still work to be done for normal property bindings.

PR Close angular#28355
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
@kara @vetom
feat(ivy): support property bindings and interpolations in DebugEleme…
f31756f 
…nt (angular#28355)

DebugElement.properties should contain a map of element
property names to element property values, with entries
for both normal property bindings and host bindings.

This commit adds support for property bindings in
DebugElement.properties (including interpolations).

PR Close angular#28355
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource left review comments

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kara @mhevery @jelbourn @pkozlowski-opensource @googlebot