fix(ivy): verify bootstrapped types are Components #28386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change we didn't verify types passed to bootstrap as a part of NgModule semantics verification. Now we check whether all types passed to bootstrap are actually Components.
AndrewKushnir
added
type: bug/fix
action: review
alfaproject
reviewed
Jan 26, 2019
alxhub
approved these changes
Jan 29, 2019
kara
removed
the
action: review
vetom
pushed a commit
to vetom/angular
that referenced
this pull request
Jan 31, 2019
Prior to this change we didn't verify types passed to bootstrap as a part of NgModule semantics verification. Now we check whether all types passed to bootstrap are actually Components. PR Close angular#28386
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change we didn't verify types passed to bootstrap as a part of NgModule semantics check. Now we verify whether all types passed to bootstrap are actually Components.
The way we handle this is a bit different with VE, when VE throws an error, in Ivy we reject the Promise returned by
bootstrapModulefunction. This seems more consistent with the rest of the cases inbootstrap_spec.tswhen we reject the promise instead of throwing an error.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?