fix(ivy): remove query results from destroyed embedded views #28445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
action: review
JoostK
reviewed
Jan 30, 2019
| @@ -127,7 +127,8 @@ export function isComponentDef<T>(def: DirectiveDef<T>): def is ComponentDef<T> | |||
| return (def as ComponentDef<T>).template !== null; | |||
| } | |||
|
|
|||
| export function isLContainer(value: RElement | RComment | LContainer | StylingContext): boolean { | |||
| export function isLContainer( | |||
| value: RElement | RComment | LContainer | LView | StylingContext | null): boolean { | |||
There was a problem hiding this comment.
We can let TypeScript narrow the type of value after this call, would avoid some casts :)
Suggested change
| value: RElement | RComment | LContainer | LView | StylingContext | null): boolean { | |
| value: RElement | RComment | LContainer | LView | StylingContext | null): value is LContainer { |
kara
approved these changes
Jan 30, 2019
| @@ -242,14 +242,17 @@ export function destroyViewTree(rootView: LView): void { | |||
| while (viewOrContainer) { | |||
| let next: LView|LContainer|null = null; | |||
|
|
|||
| if (viewOrContainer.length >= HEADER_OFFSET) { | |||
| if (isLContainer(viewOrContainer)) { | |||
kara
added
action: presubmit
kara
added
action: merge
matsko
added a commit
to matsko/angular
that referenced
this pull request
Feb 4, 2019
…ngular#28445) This reverts commit 71b9d55.
matsko
pushed a commit
that referenced
this pull request
Feb 6, 2019
matsko
added a commit
to matsko/angular
that referenced
this pull request
Feb 6, 2019
…ngular#28445) This reverts commit 5ebc0da.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.