ci: fix symbol test to handle duplicate symbols #28459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kara
added
the
area: build & ci
kara
added
the
action: review
alexeagle
reviewed
Jan 30, 2019
alexeagle
approved these changes
Jan 30, 2019
kara
added
state: WIP
action: review
In 7cb8396, we improved the symbol test to remove suffixes from the output, so "CIRCULAR$1" became "CIRCULAR". However, the logic that checked for extra symbols depended on each symbol being unique. If multiple symbols with the same name were added (e.g. pulled in from separate files), they would be added to the map as "extras", even if they were marked as expected in the golden file. This commit updates the symbol checking logic to take multiple symbols with the same name into account. Closes angular#28406
mhevery
approved these changes
Jan 30, 2019
kara
added
action: merge
|
merge-assistance: integration test failing due to #28460 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7cb8396, we improved the symbol test to remove suffixes from
the output, so "CIRCULAR$1" became "CIRCULAR". However, the logic
that checked for extra symbols depended on each symbol being unique.
If multiple symbols with the same name were added (e.g. pulled in
from separate files), they would be added to the map as "extras",
even if they were marked as expected in the golden file.
This commit updates the symbol checking logic to take multiple
symbols with the same name into account.
Closes #28406