Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bazel): Explain explicit version requirement #28482

Closed
wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Feb 1, 2019

Mention the version requirements instead of just @angular/bazel@next

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau added target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules labels Feb 1, 2019
@kyliau kyliau requested a review from mgechev February 1, 2019 01:24
@kyliau kyliau requested a review from a team as a code owner February 1, 2019 01:24
@ngbot ngbot bot added this to the needsTriage milestone Feb 1, 2019
Copy link
Member

@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments

@kyliau kyliau force-pushed the bazel-docs branch 2 times, most recently from ce6e108 to e975f28 Compare February 2, 2019 01:20
@kyliau
Copy link
Contributor Author

kyliau commented Feb 2, 2019

@mgechev All comments addressed, PTAL.
Thank you!

@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Feb 3, 2019
@matsko matsko closed this in a98d660 Feb 4, 2019
@kyliau kyliau deleted the bazel-docs branch March 22, 2019 22:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants