Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix shadow variable in tutorial example #28499

Closed
wants to merge 1 commit into from
Closed

docs: fix shadow variable in tutorial example #28499

wants to merge 1 commit into from

Conversation

Hearen
Copy link
Contributor

@Hearen Hearen commented Feb 2, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain the motivation for this change?

It would have been easier for us to review this change ifbthe motivation was captured in the commit message body.

@Hearen
Copy link
Contributor Author

Hearen commented Feb 3, 2019

@IgorMinar This is a tiny issue I found when following the tutorial, my VSCode just warn me of this hero will be shadowed by the parameter who has the same name as hero while actually the hero object should be a new hero returned from backend.

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! That makes sense. Thank you! Please include this kind of explanation in future PRs. Thanks again.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release comp: docs labels Feb 3, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 3, 2019
matsko pushed a commit that referenced this pull request Feb 4, 2019
@matsko matsko closed this in 1e5012b Feb 4, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants