Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enter notes on ivy-related material test errors #28527

Closed
wants to merge 1 commit into from
Closed

test: enter notes on ivy-related material test errors #28527

wants to merge 1 commit into from

Conversation

andrewseguin
Copy link
Contributor

Updates the latest findings of the material2 test errors when running with ivy

@andrewseguin andrewseguin added area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release labels Feb 4, 2019
@andrewseguin andrewseguin requested a review from a team as a code owner February 4, 2019 21:28
@ngbot ngbot bot added this to the needsTriage milestone Feb 4, 2019
jelbourn
jelbourn approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kara
kara approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending one nit

tools/material-ci/angular_material_test_blacklist.js Outdated Show resolved Hide resolved
@kara kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 5, 2019
@andrewseguin andrewseguin force-pushed the update-material-errors branch 2 times, most recently from bee5073 to 5ea286d Compare February 5, 2019 17:30
@kara kara removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 5, 2019
@andrewseguin andrewseguin requested a review from a team as a code owner February 5, 2019 20:59
@kara kara added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Feb 5, 2019
kara
kara approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara
Copy link
Contributor

kara commented Feb 5, 2019

merge-assistance: one core approval should be sufficient for this file (the dev-infra group was requested before the CODEOWNERS change, #28531, went in)

@matsko matsko closed this in 63b744b Feb 6, 2019
@kara kara added the comp: ivy label Feb 25, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewseguin @kara @jelbourn @googlebot