build: update to rules_typescript 0.23.2 and rules_nodejs 0.16.8 #28532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
rules-typescript-0.23.0
branch
from
3864b56
to
9ff399a
Compare
|
Should https://github.com/angular/angular/blob/master/packages/bazel/check_version.js be removed as well? |
gregmagolan
force-pushed
the
rules-typescript-0.23.0
branch
from
9ff399a
to
71dcad9
Compare
That can stay for now. We can't use @bazel/angular to installed the angular workspace yet while angular is still being built from source downstream |
alexeagle
approved these changes
Feb 5, 2019
| name = "npm", | ||
| # Need a reference to @angular here so that Bazel sets up the | ||
| # external repository before calling yarn_install | ||
| data = ["@angular//:LICENSE"], |
There was a problem hiding this comment.
yuck...good thing users shouldn't see this file
gregmagolan
added
the
area: bazel
gregmagolan
added
the
target: patch
gregmagolan
force-pushed
the
rules-typescript-0.23.0
branch
2 times, most recently
from
c401262
to
cf1a55f
Compare
gregmagolan
force-pushed
the
rules-typescript-0.23.0
branch
from
cf1a55f
to
b9f0582
Compare
kyliau
approved these changes
Feb 5, 2019
matsko
added
target: major
matsko
pushed a commit
that referenced
this pull request
Feb 5, 2019
matsko
pushed a commit
that referenced
this pull request
Feb 5, 2019
matsko
pushed a commit
that referenced
this pull request
Feb 5, 2019
matsko
pushed a commit
that referenced
this pull request
Feb 5, 2019
matsko
pushed a commit
that referenced
this pull request
Feb 5, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.