Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): fixed typo #28618

Closed
wants to merge 1 commit into from
Closed

docs(core): fixed typo #28618

wants to merge 1 commit into from

Conversation

Potapy4
Copy link
Contributor

@Potapy4 Potapy4 commented Feb 8, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #28483

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Fixes #28483

@Potapy4 Potapy4 requested a review from a team as a code owner February 8, 2019 12:08
@Potapy4
Copy link
Contributor Author

Potapy4 commented Feb 8, 2019

@gkalpak alright, my previous pull request (#28488) is a bit confusing, so I decided to recreate this

@gkalpak gkalpak added type: bug/fix action: merge The PR is ready for merge by the caretaker comp: docs target: patch This PR is targeted for the next patch release labels Feb 8, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 8, 2019
@gkalpak gkalpak added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Feb 8, 2019
@gkalpak
Copy link
Member

gkalpak commented Feb 8, 2019

merge-assistance: This is a docs-only change and I am using my global approval.

@mhevery mhevery closed this in d91ea2c Feb 8, 2019
mhevery pushed a commit that referenced this pull request Feb 8, 2019
@Potapy4 Potapy4 deleted the fix_typo branch February 9, 2019 10:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Typo in Hierarchical Dependency Injectors doc
3 participants