build: remove legacy e2e tests job #28645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
force-pushed
the
build/convert-largetable-benchmarks-to-bazel
branch
2 times, most recently
from
5cd0e47
to
755630e
Compare
devversion
added
area: build & ci
devversion
added
the
action: review
devversion
changed the title
devversion
force-pushed
the
build/convert-largetable-benchmarks-to-bazel
branch
3 times, most recently
from
1cbcd06
to
5e8f802
Compare
Switches the `largeform` benchmarks to Bazel. This is the last remaining e2e test within `modules/`.
* Updates the instructions on how to run the benchmark tests. * Removes the unused `favicon.ico` file and the corresponding Bazel filegroup
Now that all e2e integration tests within `modules/` have been migrated to Bazel, we can remove the legacy e2e tests job.
devversion
force-pushed
the
build/convert-largetable-benchmarks-to-bazel
branch
from
5e8f802
to
3388e0d
Compare
IgorMinar
added
action: merge
|
merge-assistance: the bot seems confused. this pr should be green. |
|
This PR does not apply cleanly to patch brach. Pleas break this up into a master PR and batch PR and ping for re-merge. |
|
Here is the patch version of this PR: #28697 |
devversion
added
target: major
mhevery
pushed a commit
that referenced
this pull request
Feb 13, 2019
mhevery
pushed a commit
that referenced
this pull request
Feb 13, 2019
Switches the `largeform` benchmarks to Bazel. This is the last remaining e2e test within `modules/`. PR Close #28645
mhevery
pushed a commit
that referenced
this pull request
Feb 13, 2019
* Updates the instructions on how to run the benchmark tests. * Removes the unused `favicon.ico` file and the corresponding Bazel filegroup PR Close #28645
mhevery
pushed a commit
that referenced
this pull request
Feb 13, 2019
Now that all e2e integration tests within `modules/` have been migrated to Bazel, we can remove the legacy e2e tests job. PR Close #28645
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for changes
Though most lack of commit descriptions as there is not too much to write about..