Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify hierarchical injectors #28700

Closed

Conversation

kapunahelewong
Copy link
Contributor

@kapunahelewong kapunahelewong commented Feb 13, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: Closes #28508

What is the new behavior?

  • Corrects @NgModule.providedIn to @NgModule providers array.
  • Clarifies limiting where a service is available
  • Specifies terms ModuleInjector and ElementInjector alongside current description.
  • Improves some grammar by replacing passive voice with active.
  • Adds new sections for @Optional(), @Self(), @SkipSelf(), and@Host()
  • Adds new diagrams
  • Adds new example for resolution modifiers

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

7/31 To do: write e2e tests and check for flow

@kapunahelewong kapunahelewong requested a review from a team as a code owner February 13, 2019 18:07
@kapunahelewong kapunahelewong added effort1: hours target: patch This PR is targeted for the next patch release docsarea: DI labels Feb 13, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 13, 2019
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
@kapunahelewong kapunahelewong changed the title docs: clarify hierarchical injectors [WIP]docs: clarify hierarchical injectors Feb 13, 2019
@kapunahelewong kapunahelewong force-pushed the di-clarify-providedin branch 2 times, most recently from 05700db to c26634f Compare February 28, 2019 17:28
@kapunahelewong kapunahelewong force-pushed the di-clarify-providedin branch 2 times, most recently from deea288 to 57365e7 Compare March 11, 2019 16:42
@kapunahelewong kapunahelewong force-pushed the di-clarify-providedin branch 2 times, most recently from 323e1a4 to 33defe2 Compare March 14, 2019 15:00
@kapunahelewong kapunahelewong changed the title [WIP]docs: clarify hierarchical injectors docs: clarify hierarchical injectors Mar 14, 2019
@mary-poppins
Copy link

You can preview 33defe2 at https://pr28700-33defe2.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 98773f5 at https://pr28700-98773f5.ngbuilds.io/.

aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
aio/content/guide/hierarchical-dependency-injection.md Outdated Show resolved Hide resolved
@mary-poppins
Copy link

You can preview f8691eb at https://pr28700-f8691eb.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 9d7e432 at https://pr28700-9d7e432.ngbuilds.io/.

@mary-poppins
Copy link

You can preview d1a1fd5 at https://pr28700-d1a1fd5.ngbuilds.io/.

@mary-poppins
Copy link

You can preview f4e3f3a at https://pr28700-f4e3f3a.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 9601403 at https://pr28700-9601403.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 2c0bed7 at https://pr28700-2c0bed7.ngbuilds.io/.

@mary-poppins
Copy link

You can preview bf33843 at https://pr28700-bf33843.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 40830de at https://pr28700-40830de.ngbuilds.io/.

@kapunahelewong kapunahelewong added the action: merge The PR is ready for merge by the caretaker label Aug 15, 2019
@kapunahelewong
Copy link
Contributor Author

Caretaker, this one's big (though is docs only) so if you need me, please let me know. Thank you!!!

@AndrewKushnir
Copy link
Contributor

@kapunahelewong thanks for the update. Could you please rebase this PR on top of the latest master (since last rebase was 9 days agi), so we can run CI again to make sure it'd green? Thank you.

@mary-poppins
Copy link

You can preview 6606a65 at https://pr28700-6606a65.ngbuilds.io/.

AndrewKushnir pushed a commit that referenced this pull request Aug 15, 2019
@jbogarthyde jbogarthyde moved this from In Review to Done in docs Aug 28, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
@kapunahelewong kapunahelewong deleted the di-clarify-providedin branch June 23, 2020 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours freq2: medium refactoring Issue that involves refactoring or code-cleanup risk: medium target: patch This PR is targeted for the next patch release
Projects
docs
Done
Development

Successfully merging this pull request may close these issues.

docs: Hierarchical Injectors document is a bit misleading.
6 participants