New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify hierarchical injectors #28700
docs: clarify hierarchical injectors #28700
Conversation
1a9d885
to
a76e16d
Compare
05700db
to
c26634f
Compare
deea288
to
57365e7
Compare
323e1a4
to
33defe2
Compare
You can preview 1a9d885 at https://pr28700-1a9d885.ngbuilds.io/. |
You can preview 33defe2 at https://pr28700-33defe2.ngbuilds.io/. |
33defe2
to
98773f5
Compare
You can preview 98773f5 at https://pr28700-98773f5.ngbuilds.io/. |
98773f5
to
f8691eb
Compare
You can preview f8691eb at https://pr28700-f8691eb.ngbuilds.io/. |
You can preview 9d7e432 at https://pr28700-9d7e432.ngbuilds.io/. |
9d7e432
to
d1a1fd5
Compare
You can preview d1a1fd5 at https://pr28700-d1a1fd5.ngbuilds.io/. |
d1a1fd5
to
f4e3f3a
Compare
You can preview f4e3f3a at https://pr28700-f4e3f3a.ngbuilds.io/. |
f4e3f3a
to
9601403
Compare
You can preview 9601403 at https://pr28700-9601403.ngbuilds.io/. |
9601403
to
2c0bed7
Compare
You can preview 2c0bed7 at https://pr28700-2c0bed7.ngbuilds.io/. |
2c0bed7
to
bf33843
Compare
You can preview bf33843 at https://pr28700-bf33843.ngbuilds.io/. |
bf33843
to
40830de
Compare
You can preview 40830de at https://pr28700-40830de.ngbuilds.io/. |
Caretaker, this one's big (though is docs only) so if you need me, please let me know. Thank you!!! |
@kapunahelewong thanks for the update. Could you please rebase this PR on top of the latest master (since last rebase was 9 days agi), so we can run CI again to make sure it'd green? Thank you. |
40830de
to
6606a65
Compare
You can preview 6606a65 at https://pr28700-6606a65.ngbuilds.io/. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: Closes #28508
What is the new behavior?
@NgModule.providedIn
to@NgModule
providers
array.ModuleInjector
andElementInjector
alongside current description.@Optional()
,@Self()
,@SkipSelf()
, and@Host()
Does this PR introduce a breaking change?
Other information
7/31 To do: write e2e tests and check for flow