build: remove legacy-unit-tests-local job #28703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
force-pushed
the
build/run-example-unit-tests-with-bazel
branch
from
0793191
to
065d1d6
Compare
devversion
changed the title
devversion
added
target: major
devversion
added
target: patch
IgorMinar
added
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
With angular#28402 we updated the `examples` package to be built and tested with Bazel. This PR was only intended for the e2e integration tests, and there still seem to be a few unit tests that need to be migrated to Bazel until we can remove the legacy local unit tests job.
Since all unit tests are now run with Bazel, we can remove the local legacy unit tests job. We still need to keep the Saucelabs legacy job until we can run all of these web unit tests with Saucelabs and Bazel.
devversion
force-pushed
the
build/run-example-unit-tests-with-bazel
branch
from
065d1d6
to
6f431da
Compare
devversion
removed
the
action: cleanup
IgorMinar
pushed a commit
that referenced
this pull request
Feb 21, 2019
Since all unit tests are now run with Bazel, we can remove the local legacy unit tests job. We still need to keep the Saucelabs legacy job until we can run all of these web unit tests with Saucelabs and Bazel. PR Close #28703
IgorMinar
pushed a commit
that referenced
this pull request
Feb 21, 2019
Since all unit tests are now run with Bazel, we can remove the local legacy unit tests job. We still need to keep the Saucelabs legacy job until we can run all of these web unit tests with Saucelabs and Bazel. PR Close #28703
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
I've also made some coverage comparisons for Bazel tests vs legacy unit tests and everything looks if we remove the legacy unit tests job. All spec files being run in the legacy job are also running with Bazel.
https://docs.google.com/document/d/1SD2qEGm22yehmJLmeYodgP2eRyCXNuZtYTZj3WuAldg/edit?usp=sharing