Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify behavior of dependency injection at root injector #28753

Closed
wants to merge 1 commit into from
Closed

docs: clarify behavior of dependency injection at root injector #28753

wants to merge 1 commit into from

Conversation

Potapy4
Copy link
Contributor

@Potapy4 Potapy4 commented Feb 15, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: ##28748

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Fixes #28748

@Potapy4 Potapy4 requested a review from a team as a code owner February 15, 2019 10:06
@brandonroberts brandonroberts self-assigned this Feb 19, 2019
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update git commit message to docs: clarify behavior of dependency injection at root injector

@brandonroberts brandonroberts changed the title docs(core): clarified the DI's behavior docs: clarify behavior of dependency injection at root injector Feb 19, 2019
@brandonroberts brandonroberts added type: bug/fix action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews comp: docs effort1: hours risk: low labels Feb 19, 2019
@ngbot ngbot bot added this to the Backlog milestone Feb 19, 2019
@Potapy4
Copy link
Contributor Author

Potapy4 commented Feb 19, 2019

@brandonroberts ready

@brandonroberts brandonroberts added target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 19, 2019
@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Feb 19, 2019
@IgorMinar IgorMinar closed this in 9e82ceb Feb 19, 2019
@Potapy4 Potapy4 deleted the patch-1 branch March 12, 2019 10:26
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: the DI framework should throws an error
3 participants